Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firebird backend #12

Open
iwbnwif opened this issue Oct 20, 2015 · 3 comments
Open

Add Firebird backend #12

iwbnwif opened this issue Oct 20, 2015 · 3 comments
Labels
Help Needed Consider contributing a PR to fix this issue

Comments

@iwbnwif
Copy link
Contributor

iwbnwif commented Oct 20, 2015

I would like to propose implementing a Firebird backend based on IBPP.

This would make IBPP a sort of dependency, but given it comes as open source .cpp and .h files it can live in /vendors.

If this is approved then it would be a thinish wrapper around IBPP rather than an update of the wxDatabaseLayer Firebird backend. In future IBPP might be replaced by the new Firebird 3 OO API, but we should wait for things to stabilize first.

@mtangoo
Copy link
Owner

mtangoo commented Oct 20, 2015

are you willing to add and maintain that one? I don't use FB and have zero idea about it.
I will add it if you can make one and agree to maintain it

@iwbnwif
Copy link
Contributor Author

iwbnwif commented Oct 20, 2015

I will add it first using the PR mechanism you described earlier. Once it is working and stable we can decide if it is viable to be added to the main code. I wanted to add this ticket (how do I set "Enhancement"?) so we can discuss it here :)

@mtangoo
Copy link
Owner

mtangoo commented Oct 20, 2015

Yes, fork it and add it in your fork and make tests there. Once its working, you can do a PR
@manyleaves can you help here on unit tests thing. I'm zero at that :)

@mtangoo mtangoo added the Help Needed Consider contributing a PR to fix this issue label Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Needed Consider contributing a PR to fix this issue
Projects
None yet
Development

No branches or pull requests

2 participants