Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardtrader Kaldheim theme boosters black and white are flipped #238

Open
kodawah opened this issue Sep 6, 2024 · 3 comments
Open

cardtrader Kaldheim theme boosters black and white are flipped #238

kodawah opened this issue Sep 6, 2024 · 3 comments

Comments

@kodawah
Copy link
Contributor

kodawah commented Sep 6, 2024

https://www.mtgban.com/sealed?q=Kaldheim+Theme+Booster+White -> https://www.cardtrader.com/cards/kaldheim-theme-black-booster-kaldheim

in general the theme boosters on CT are pretty much messed up because (for the most part) they don't tag the different series, should we maybe just drop them if they are duplicated?

@axxroytovu
Copy link
Collaborator

For a lot of the theme boosters they just give an order 1-5 or 1-6 and I had to assume that they were in WUBRG order. If you find any issues feel free to swap them.

@kodawah
Copy link
Contributor Author

kodawah commented Sep 7, 2024

I've just checked, they don't do anything, version field is always empty, and the name is the same
I believe the number suffix we see is implementation dependent on the yaml library we use, so the order is fully random, sadly

@axxroytovu
Copy link
Collaborator

I went by ascending ID number but yeah it's probably random.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants