Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update explore page filtering to respect selected area type #335

Closed
2 tasks done
Tracked by #256
struan opened this issue Nov 7, 2023 · 5 comments
Closed
2 tasks done
Tracked by #256

update explore page filtering to respect selected area type #335

struan opened this issue Nov 7, 2023 · 5 comments

Comments

@struan
Copy link
Member

struan commented Nov 7, 2023

  • update JS to pass the current area type to the filter end point
  • update the filtering to select data for the relevant area type
@struan
Copy link
Member Author

struan commented Nov 8, 2023

I think as part of this I'm going to have to add something to the dataset to indicate which area types it's available for.

I think this makes sense and seems much less fraught then trying to derive the information elsewhere.

I am thinking that adding:

areas_available = models.ManyToManyField(AreaType)

to DataSet is the best option, anyone have any thoughts on this @zarino @alexander-griffen

It will mean yet another update to the imports to add this, although I guess I can maybe assume if this is null then it means it applies to WMC types.

@struan
Copy link
Member Author

struan commented Nov 8, 2023

Although doh! the data_type has an area_type on it so maybe I don't need this...

@struan
Copy link
Member Author

struan commented Nov 8, 2023

Having thought about this a bit more, and written some code I think I do need this as it's going to make things much easier.

struan added a commit that referenced this issue Nov 9, 2023
Otherwise you end up with no areas returned if you select a dataset
that's not available for the area type

Fixes #335
struan added a commit that referenced this issue Nov 9, 2023
Otherwise you end up with no areas returned if you select a dataset
that's not available for the area type

Fixes #335
@zarino
Copy link
Member

zarino commented Nov 20, 2023

This is being / has been addressed as part of #344

struan added a commit that referenced this issue Nov 21, 2023
Otherwise you end up with no areas returned if you select a dataset
that's not available for the area type

Fixes #335
@zarino
Copy link
Member

zarino commented Nov 23, 2023

@struan I think this can be closed now, as #344 has been merged into #350 / multiple-geometry-staging?

@struan struan closed this as completed Nov 23, 2023
struan added a commit that referenced this issue Dec 6, 2023
Otherwise you end up with no areas returned if you select a dataset
that's not available for the area type

Fixes #335
struan added a commit that referenced this issue Dec 11, 2023
Otherwise you end up with no areas returned if you select a dataset
that's not available for the area type

Fixes #335
struan added a commit that referenced this issue Jan 11, 2024
Otherwise you end up with no areas returned if you select a dataset
that's not available for the area type

Fixes #335
struan added a commit that referenced this issue Jan 22, 2024
Otherwise you end up with no areas returned if you select a dataset
that's not available for the area type

Fixes #335
struan added a commit that referenced this issue Jan 22, 2024
Otherwise you end up with no areas returned if you select a dataset
that's not available for the area type

Fixes #335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants