From 2a43d97bee0fcaf6374711461368f08f4ffa9c1e Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Thu, 18 Oct 2018 12:01:36 +1100 Subject: [PATCH 1/2] Add newline to end of shell script Currently bin/check_goimports does not end with a newline. In keeping with UNIX folklore we should have a newline on the end of a shell script file. Add newline to end of shell script file. Signed-off-by: Tobin C. Harding --- bin/check_goimports | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/check_goimports b/bin/check_goimports index d55969569a..1f107fa79f 100755 --- a/bin/check_goimports +++ b/bin/check_goimports @@ -28,4 +28,4 @@ if [ ! -z "$unformatted" ]; then fi print_success "All files are compliant to goimports." -exit 0 \ No newline at end of file +exit 0 From b4787ccc4112e2335954ccc0352cf8dc9ff8b18b Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Thu, 18 Oct 2018 12:07:45 +1100 Subject: [PATCH 2/2] Add missing 'set -e' to shell script Currently bin/check_goimports is missing `set -e` line. Add `set -e` Fixes: Issue #450 Signed-off-by: Tobin C. Harding --- bin/check_goimports | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bin/check_goimports b/bin/check_goimports index 1f107fa79f..217ebb9429 100755 --- a/bin/check_goimports +++ b/bin/check_goimports @@ -12,6 +12,8 @@ #> bin/check_goimports ./communication #> bin/check_goimports ./communication/... +set -e + source bin/helpers/output.sh ARGUMENTS=$@