Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready check should not be OK until watchers are done #84

Open
thokra-nav opened this issue Jan 23, 2025 · 0 comments
Open

Ready check should not be OK until watchers are done #84

thokra-nav opened this issue Jan 23, 2025 · 0 comments

Comments

@thokra-nav
Copy link
Contributor

If there's a CRD resource with wrong name or something similar, the watcher will fail. This allowed the service to be deployed and replace the working version.

Either the deployment is too aggressive when deploying, replacing all old instances, or it's too easy to get a 200 OK health check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant