Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OpenCV 4 #662

Closed
bcoltin opened this issue Jan 31, 2023 · 3 comments · Fixed by #781
Closed

Upgrade to OpenCV 4 #662

bcoltin opened this issue Jan 31, 2023 · 3 comments · Fixed by #781
Assignees

Comments

@bcoltin
Copy link
Member

bcoltin commented Jan 31, 2023

@ana-GT is looking into this with help from @marinagmoreira . We will try to merge this into both develop and ros2 branch assuming the changes aren't too drastic, supporting both versions at once. We will also need to upgrade the alvar debian.

@ana-GT
Copy link
Contributor

ana-GT commented Feb 6, 2023

Yes! So, I was taking a look at some existing upgrades in the community and ran across this PR : ros-perception/ar_track_alvar#89 . It is not approved yet, but from the conversation around it, it sounds it could be a good reference. I am doing some local updates in the astrobee localization code in my machine (upgrades to use OpenCV.4.x) to see if they work well together with this PR. 🤞

@ana-GT
Copy link
Contributor

ana-GT commented Feb 11, 2023

Update: Was able to compile the astrobee workspace using OpenCV 4.2 (default version in noetic) and the ar_track_alvar package I mentioned in my previous message :) . I tried the test in marker_tracking (test_marker_detector.test) and it was successful. I did not test with other harder images, though.

The OpenCV4-compatible branch is in my astrobee fork and instructions on how to install things are here: https://github.com/ana-GT/astrobee/wiki/Test-OpenCV4-branch . Other than installing OpenCV4.2 ahead and using the ar_track_alvar package from source instead of the old fork, the rest of changes are reasonably straightforward.

@bcoltin
Copy link
Member Author

bcoltin commented Feb 13, 2023

Wonderful!!! Thank you Ana, we will check it out!

@marinagmoreira marinagmoreira self-assigned this Apr 11, 2024
@marinagmoreira marinagmoreira linked a pull request Apr 26, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants