Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change sklearn to scikit-learn #52

Open
lacava opened this issue Aug 11, 2023 · 2 comments
Open

change sklearn to scikit-learn #52

lacava opened this issue Aug 11, 2023 · 2 comments

Comments

@lacava
Copy link

lacava commented Aug 11, 2023

pypi doesn't accept sklearn as a dependency anymore; has to be scikit-learn

ffx/setup.py

Line 18 in ced56d9

install_requires=['click>=5.0', 'contextlib2>=0.5.4', 'numpy', 'pandas', 'six', 'sklearn',],

@AKAL4nka
Copy link

AKAL4nka commented Dec 8, 2023

I would like to upvote this.

@jmmcd
Copy link
Collaborator

jmmcd commented Jan 29, 2025

Unfortunately I don't have permission to commit the fix directly. I do have permission to make a new release (at least, a few years ago I did!) but need to have that fix committed first. @natekupp are you active in GitHub these days?

As a workaround, this works:

$ SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True pip install ffx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants