Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require API Version per Request #104

Open
bryanculver opened this issue Feb 9, 2023 · 1 comment
Open

Require API Version per Request #104

bryanculver opened this issue Feb 9, 2023 · 1 comment
Labels
question Further information is requested

Comments

@bryanculver
Copy link
Member

Pynautbot should require the specification of desired API version for all requests (either via environment variable or config) and not use whatever Nautobot specifies as the default. This would move Pynautobot to adhere to the best practice defined in Nautobot's REST API documentation: https://docs.nautobot.com/projects/core/en/stable/rest-api/overview/#default-versions-and-backward-compatibility

@jvanderaa
Copy link
Contributor

jvanderaa commented Feb 9, 2023

Are we thinking that we need to require the api_version key when initiating a pynautobot object? @bryanculver

If that is the case, I believe that may add in some complications as far as getting started with the library. I am going to object on requiring it until there is an easy way to know what API version to use. For just getting started with the library, this adds in a complication.

@jvanderaa jvanderaa added question Further information is requested and removed type: housekeeping labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants