Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"There seems to be no custom field. Head to..." when plugin is disabled #65

Open
michael-milette opened this issue Jan 17, 2025 · 0 comments

Comments

@michael-milette
Copy link
Contributor

michael-milette commented Jan 17, 2025

HI @ndunand

I have one more small change request.

What is happening:

If the "Enrol by user profile fields" plugin is installed but not enabled, I see the message "There seems to be no custom field. Head to user settings to add one." at the top of the screen if there are no custom profile fields defined.

Image

**What I expected: **

If the plugin is installed but not enabled, I don't expect it to display any notifications.

Why would I do this?

Sometimes, I install the plugin for future use and there are no custom profile fields defined yet.

A pull request will be submitted in a few minutes. I would appreciate it if you would consider integrating the change.

Please let me know if you have any questions.

Best regards,

Michael Milette

michael-milette added a commit to michael-milette/moodle-enrol_attributes that referenced this issue Jan 17, 2025
ndunand added a commit that referenced this issue Jan 31, 2025
#65 - No longer displays no profile fields message if plugin is disabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant