From a5d6777deb990ae59b928fbdca2038cbab0d9ca2 Mon Sep 17 00:00:00 2001
From: Nicolas Alexandropoulos <Nicolas.Alexandropoulos@unil.ch>
Date: Wed, 30 Oct 2024 15:07:30 +0100
Subject: [PATCH 1/3] Improve groups tooltip on plugin settings

---
 mod_form.php | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/mod_form.php b/mod_form.php
index 0a1b55c..491b965 100644
--- a/mod_form.php
+++ b/mod_form.php
@@ -151,15 +151,8 @@ public function definition() {
         $mform->addElement('header', 'groups', get_string('groupsheader', 'choicegroup'));
         $mform->addElement('html', '<fieldset class="clearfix">
                 <div class="fcontainer clearfix">
-                <div id="fitem_id_option_0" class="fitem fitem_fselect ">
-                <div class="fitemtitle"><label for="id_option_0">' . get_string('groupsheader', 'choicegroup') .
-            '</label><span class="helptooltip"><a href="' . $CFG->wwwroot .
-            '/help.php?component=choicegroup&amp;identifier=choicegroupoptions&amp;lang=' . current_language() .
-            '" title="' . get_string('choicegroupoptions_help', 'choicegroup') .
-            '" aria-haspopup="true" target="_blank"><img height="24px" width="24px" src="' . $CFG->wwwroot . '/theme/image.php?theme='
-            . $PAGE->theme->name . '&component=core&image=help" alt="' .
-            get_string('choicegroupoptions_help', 'choicegroup') .
-            '" class="iconhelp"></a></span></div><div class="felement fselect">
+                <div id="fitem_id_option_0" name="fitem_id_option_0" class="fitem fitem_fselect ">
+                <div class="felement fselect">
                 <div class="tablecontainer">
                 <table>
                     <tr class="row">
@@ -168,6 +161,7 @@ public function definition() {
                     </tr>
                     <tr class="row">
                         <td style="vertical-align: top" class="col-5">');
+        $mform->addHelpButton('groups', 'choicegroupoptions', 'choicegroup');
 
         $mform->addElement('html', '<select class="col-12" id="availablegroups" name="availableGroups" multiple size=10>');
         foreach ($groupings as $groupingid => $grouping) {

From 0fa5ae3a10d687d4deb2e695aa0393ff6442bfbb Mon Sep 17 00:00:00 2001
From: Nicolas Alexandropoulos <Nicolas.Alexandropoulos@unil.ch>
Date: Mon, 11 Nov 2024 18:52:55 +0100
Subject: [PATCH 2/3] Add missing label in plugin settings

---
 lang/en/choicegroup.php | 1 +
 mod_form.php            | 1 +
 2 files changed, 2 insertions(+)

diff --git a/lang/en/choicegroup.php b/lang/en/choicegroup.php
index 6ccf38c..be8cc3d 100644
--- a/lang/en/choicegroup.php
+++ b/lang/en/choicegroup.php
@@ -57,6 +57,7 @@
 $string['choicegroupname'] = 'Group choice name';
 $string['choicegroupopen'] = 'Open';
 $string['choicegroupoptions'] = 'Choice options';
+$string['choicegroupoptions_description'] = 'Define available group options for participants';
 $string['choicegroupoptions_help'] = 'Here is where you specify which groups participants can choose from.
 
 The list on the left displays all available groups and groupings. To add one or several groups, select these from the list and click "Add". To add all groups from a grouping, select the grouping and click "Add".
diff --git a/mod_form.php b/mod_form.php
index 491b965..05e49fd 100644
--- a/mod_form.php
+++ b/mod_form.php
@@ -151,6 +151,7 @@ public function definition() {
         $mform->addElement('header', 'groups', get_string('groupsheader', 'choicegroup'));
         $mform->addElement('html', '<fieldset class="clearfix">
                 <div class="fcontainer clearfix">
+                <label for="fitem_id_option_0" class="fitemtitle">' . get_string('choicegroupoptions_description', 'choicegroup') . '</label>
                 <div id="fitem_id_option_0" name="fitem_id_option_0" class="fitem fitem_fselect ">
                 <div class="felement fselect">
                 <div class="tablecontainer">

From cda36aea2a13b44496c4562832902b385ddac7c6 Mon Sep 17 00:00:00 2001
From: Nicolas Alexandropoulos <Nicolas.Alexandropoulos@unil.ch>
Date: Mon, 11 Nov 2024 19:09:44 +0100
Subject: [PATCH 3/3] Fix line length issue

---
 mod_form.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mod_form.php b/mod_form.php
index 05e49fd..3935a7a 100644
--- a/mod_form.php
+++ b/mod_form.php
@@ -151,7 +151,8 @@ public function definition() {
         $mform->addElement('header', 'groups', get_string('groupsheader', 'choicegroup'));
         $mform->addElement('html', '<fieldset class="clearfix">
                 <div class="fcontainer clearfix">
-                <label for="fitem_id_option_0" class="fitemtitle">' . get_string('choicegroupoptions_description', 'choicegroup') . '</label>
+                <label for="fitem_id_option_0" class="fitemtitle">'
+                    . get_string('choicegroupoptions_description', 'choicegroup') . '</label>
                 <div id="fitem_id_option_0" name="fitem_id_option_0" class="fitem fitem_fselect ">
                 <div class="felement fselect">
                 <div class="tablecontainer">