Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keystore_path in Info doesn't appear to be in use #196

Open
joshuajbouw opened this issue Sep 20, 2022 · 2 comments
Open

keystore_path in Info doesn't appear to be in use #196

joshuajbouw opened this issue Sep 20, 2022 · 2 comments

Comments

@joshuajbouw
Copy link
Member

It would be quite handy to be able to import your keys and have access to them in the Sandbox, Testnet and Mainnet workers. However, it only sets the path for these credentials but does not load the keys themselves.

Solution

I do not exactly see an actual benefit to holding this information as it isn't used anywhere in the code. What would be nice if there was a key loader where you can have access to your accounts however!

@frol
Copy link
Collaborator

frol commented Oct 4, 2023

@joshuajbouw What you are asking is a bad practice of storing keys in plain text on disk, and if you implement such a test with the workspaces-rs, you will need to replicate this insecure design on CI as well. I am hesitant to promote such bad practices to the community.

@shariffdev Since you jumped on it, I recommend you think about the problem space more holistically, and design a solution that would be convenient, but not compromised on security.

@ghost
Copy link

ghost commented Oct 5, 2023

@frol I'll sit on it and check on strategies that can pull this off but also fit in place with the CI. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: NEW❗
Development

Successfully merging a pull request may close this issue.

2 participants