Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore using single sandbox instance #64

Open
ChaoticTempest opened this issue Jan 27, 2022 · 0 comments · May be fixed by #71
Open

Explore using single sandbox instance #64

ChaoticTempest opened this issue Jan 27, 2022 · 0 comments · May be fixed by #71
Assignees

Comments

@ChaoticTempest
Copy link
Member

ChaoticTempest commented Jan 27, 2022

Currently, all workspaces::sandbox() calls will spin up a new sandbox instance. This was to prevent non-determinism from multiple tests hitting the same node and potentially spinning up similarly sounding accounts and/or modifying similar data with patch state. But this might not be the best for most use-cases and I think we can be less strict about this.

I think we can switch the defaults over to using a single sandbox, and if users are experiencing this non-determinism, they can switch it back over to multiple sandbox. I'm not sure this is the best default, but this is very open to opinions so comment if there's anything that could be worked out better.

Alternatively, we can have an extra macro for each test that points to the port for the sandbox like #<span class="error">[sandbox::at_port(3030)]</span> or #<span class="error">[sandbox::multi_instance]</span>. Or if we don't want to use macros, we can have it be a separate function like workspaces::sandbox_on(3030).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: NEW❗
Development

Successfully merging a pull request may close this issue.

2 participants