-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Upgrade to jdk 17 and SpringBoot 3.x #217
Draft: Upgrade to jdk 17 and SpringBoot 3.x #217
Conversation
springboot2.x is still supported? |
@1244453393, I never tested this but I don't think it's possible. At least without having additional considerations. |
people who use the springboot2.x are still the majority |
What about maintaining two different releases ? It adds more efforts obviously but how would you else go with this issue internally ? |
1 similar comment
What about maintaining two different releases ? It adds more efforts obviously but how would you else go with this issue internally ? |
there is currently no great solution,but the version transition is not very fast,this gives us ample time to study how to upgrade to the new version!XD |
My idea is that a new branch can be created. I'll probably have some time to try on springboot3.x this Wednesday, and then I'll take a look at the problems. |
I may have found the root cause of the problem. Run the following code, and the results differ between java8 and java17. Class.forName("java.util.Arrays$ArrayList").getMethod("get", int.class).setAccessible(true); The param can't use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omar-araboghli
I tried to work basically on Springboot3.x, with the exception of some of the original Array.asList test cases. Another use case that reads mapping relationships from PathWrapper is still misreporting, which is a functional flaw.
QueryException may be caused by the fact that the database does not have a schema that matches the test case.
At present, in addition to some conflicts, this PR has some codestyle problems to be solved.
It's possible to work properly. Thank you for your time.
I suggest creating another branch to be compatible with springboot3.x with a higher version number.
cc:@wey-gu
Closes #216
I tried to cover as much as possible but there are still missing things. Maybe you guys could help.
/ngbatis-demo
due to aorg.nebula.contrib.ngbatis.exception.QueryException
. Is there a certain config I should do when setting up the project ?BeetlTextRenderTest.test2()
is failing with following exception. Any help with that from your side ? I unfortunately couldn't know where that is originating from.