Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Ability to separate property name with "_" for environment variables #6

Open
szpak opened this issue Oct 17, 2014 · 4 comments
Open

Comments

@szpak
Copy link
Contributor

szpak commented Oct 17, 2014

Bash, Fish and probably many other Linux shells don't allow to use . (dot) in an environment variable name. Therefore it is not possible to separate plugin name and property name.

export OVERRIDE_pitest.targetClasses=foo

bash: export: `OVERRIDE_pitest.targetClasses=foo': not a valid identifier

_ (underscore) could be used as an replacement.

@quidryan
Copy link
Contributor

Underscore is also how Gradle specifies properties as environment
variables: ORG_GRADLE_PROJECT__prop_=somevalue (
http://www.gradle.org/docs/current/userguide/tutorial_this_and_that.html)

On Fri, Oct 17, 2014 at 3:18 PM, Marcin Zajączkowski <
[email protected]> wrote:

Bash, Fish and probably many other Linux shells don't allow to use .
(dot) in an environment variable name. Therefore it is not possible to
separate plugin name and property name.

export OVERRIDE_pitest.targetClasses=foo

bash: export: `OVERRIDE_pitest.targetClasses=foo': not a valid identifier

`_" (underscore) could be used as an replacement.


Reply to this email directly or view it on GitHub
#6.

@bmuschko
Copy link
Contributor

@szpak Would you be interested in working on a fix for this?

@szpak
Copy link
Contributor Author

szpak commented Oct 24, 2014

@bmuschko I can add it to my open source project's contribution TODO list, but it is already very long and it would not have a high priority as I don't use mentioned feature. I just spotted it when I tested parameter quoting for #3.

@jmcgarr
Copy link

jmcgarr commented Apr 18, 2017

We are doing some housecleaning and we consider this plugin "feature complete". Since this is an enhancement, we will accept PR's but won't be able to prioritize this enhancement. Otherwise we will close this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants