Rename mods.toml to neoforge.mods.toml

[Matyrobbrt]

This is targeted for a new major (in 1.20.5).
By renaming the file, we can improve error reporting in case Forge mods are found, and not attempt to load them. 3rd party tools can also use the presence or absence of this file to determine the loader of the mod.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: 737381c42b5ddd9767cd3e7a679946592f4d02f7.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged.fancymodloader:spi:2.0.21-pr-100-modsdottoml-rename
• 📦 net.neoforged.fancymodloader:earlydisplay:2.0.21-pr-100-modsdottoml-rename
• 📦 net.neoforged.fancymodloader:loader:2.0.21-pr-100-modsdottoml-rename

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #100' // https://github.com/neoforged/FancyModLoader/pull/100
        url 'https://prmaven.neoforged.net/FancyModLoader/pr100'
        content {
            includeModule('net.neoforged.fancymodloader', 'spi')
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
            includeModule('net.neoforged.fancymodloader', 'loader')
        }
    }
}

[0xilly]

We either follow the vote or we don’t the “small enough to ignore” excuse doesn’t cut it IMHO Anita Anderson

…

On Mar 21, 2024, at 4:44 PM, Technici4n ***@***.***> wrote: @Technici4n commented on this pull request. --------------------------------------------------------------- In [loader/src/main/java/net/neoforged/fml/loading/moddiscovery/AbstractModProvider.java](#100 (comment)): > @@ -29,7 +29,7 @@ public abstract class AbstractModProvider implements IModProvider { private static final Logger LOGGER = LogUtils.getLogger(); - protected static final String MODS_TOML = "META-INF/mods.toml"; I think that the opinion is clear enough. Voting should be a last resort option anyway. — Reply to this email directly, [view it on GitHub](#100 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAKFA4RXVLEPZ3UG4SPVD7DYZNBB3AVCNFSM6AAAAABE64VQB2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJTGM4DEOJXGE). You are receiving this because you commented.Message ID: ***@***.***>

[Technici4n]

The vote decided between 1) root folder or META-INF and 2) whether to rename the file or not. So we rename the file and keep it in META-INF. Orion wasn't happy because maty forgot to keep the file in META-INF (now this is fixed). Other than that, there's no objection that I'm aware of.