Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Publication 1.20.6 #1

Merged
merged 4 commits into from
Jun 5, 2024
Merged

PR Publication 1.20.6 #1

merged 4 commits into from
Jun 5, 2024

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented May 19, 2024

Do not merge this

This is intended to get a PR publication for 1.20.6

@shartte shartte changed the title PR Publication PR Publication 1.20.6 May 19, 2024
@shartte shartte closed this May 19, 2024
@shartte shartte reopened this May 19, 2024
@shartte shartte closed this May 19, 2024
@shartte shartte reopened this May 19, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 19, 2024

  • Publish PR to GitHub Packages

Last commit published: 73e382c31f965c176539e97a3ad3100a50605065.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1' // https://github.com/neoforged/GradleMinecraftDependencies/pull/1
        url 'https://prmaven.neoforged.net/GradleMinecraftDependencies/pr1'
        content {
            includeModule('net.neoforged', 'minecraft-dependencies')
        }
    }
}

@lukebemish
Copy link
Contributor

Some minor cleanups that could be useful that I've noticed that I figure should be recorded somewhere so they don't get buried in the depths of discord:

  • The client jar no longer needs to be downloaded as it's not used for anything anymore (server jar is still used for the server dependency list)
  • Any variant with the same capability GAV as the module itself and no others (so, clientRuntimeDependencies and company, but not the natives ones) can just declare no capabilities to save a bit of file size.

@shartte shartte marked this pull request as ready for review June 5, 2024 21:19
@shartte shartte merged commit 7ef690f into main Jun 5, 2024
1 of 2 checks passed
@shartte shartte deleted the publishing branch June 5, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants