Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix named attributes in legacy failing when reading back data from Module Metadata #225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Jan 8, 2025

We current have a bug where depending on a Mod that was published by MDG Legacy fails, due to that Mod containing our mappings attribute with the value "srg".

Gradle seems to be unable to map that back for some reason.

* What went wrong:
Execution failed for task ':compileKotlin'.
> Could not resolve all files for configuration ':compileClasspath'.
   > Could not resolve dev.icosider:dripper-forge:1.20.1-1.0.0.
     Required by:
         root project :
      > No enum constant net.neoforged.moddevgradle.legacyforge.internal.MinecraftMappings.srg

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 8, 2025

  • Publish PR to GitHub Packages

Last commit published: 6b5c0e2b9a6ba33b68765e5e83478a3d529ce808.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #225' // https://github.com/neoforged/ModDevGradle/pull/225
        url 'https://prmaven.neoforged.net/ModDevGradle/pr225'
        content {
            includeModule('net.neoforged.moddev.legacyforge', 'net.neoforged.moddev.legacyforge.gradle.plugin')
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
            includeModule('net.neoforged', 'moddev-gradle')
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
        }
    }
}

@Icosider
Copy link

Icosider commented Jan 8, 2025

The fix is working, I just checked it myself. Thanks

@shartte shartte marked this pull request as ready for review January 8, 2025 22:32
@shartte shartte requested a review from Matyrobbrt January 9, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants