Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: flamegraphs for pprof heap profiles #10203

Closed
erikgrinaker opened this issue Dec 19, 2024 · 0 comments · Fixed by #10223
Closed

utils: flamegraphs for pprof heap profiles #10203

erikgrinaker opened this issue Dec 19, 2024 · 0 comments · Fixed by #10223
Assignees
@erikgrinaker
Labels
a/observability Area: related to observability c/storage Component: storage

Comments

@erikgrinaker
Copy link
Contributor

Unlike CPU profiles, pprof_heap_profile() can't return a flamegraph SVG. We should implement this similarly to pprof-rs.
@erikgrinaker erikgrinaker added a/observability Area: related to observability c/storage Component: storage labels Dec 19, 2024
@erikgrinaker erikgrinaker self-assigned this Dec 19, 2024
@erikgrinaker erikgrinaker mentioned this issue Dec 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 10, 2025
@erikgrinaker
utils: add flamegraph for heap profiles (#10223)
2b8ea1e 
## Problem

Unlike CPU profiles, the `/profile/heap` endpoint can't automatically
generate SVG flamegraphs. This requires the user to install and use
`pprof` tooling, which is unnecessary and annoying.

Resolves #10203.

## Summary of changes

Add `format=svg` for the `/profile/heap` route, and generate an SVG
flamegraph using the `inferno` crate, similarly to what `pprof-rs`
already does for CPU profiles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
a/observability Area: related to observability c/storage Component: storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

utils: add flamegraph for heap profiles neondatabase/neon
1 participant
@erikgrinaker