Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace button tag with div #156

Open
monolithed opened this issue Nov 26, 2024 · 1 comment
Open

Replace button tag with div #156

monolithed opened this issue Nov 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@monolithed
Copy link

I've come across similar tickets with semantic markup, but it seems that the 'button' should not be a tag because it may contain block-level elements, which violates semantic markup principles. It would be great to replace it with a

.

@nerdyman
Copy link
Owner

Thanks for raising this @monolithed. I've looked at other slider role examples and they do indeed use div tags, not button.

I'll look at resolving this before releasing v4. Also open to PRs!

@nerdyman nerdyman added the enhancement New feature or request label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants