-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When will fileRegion be supported? #210
Comments
@1Jo1 Cloud you mind help to see this issue? |
Seems like while sendfile is not directly supported by io_uring itself it is possible to kind of create the same functionality by using splice: https://lwn.net/Articles/810482/ |
@normanmaurer I don't know much about the Linux kernel. Will netty io_uring consider using splice to implement fileRegion? |
I'm not sure there is some gap for netty io_uring to implement fileRegion by using splice. |
Yes .... I just left the comment for the future so I dont forget. I am currently busy but might implement it once I have some cycles. |
We really want to try the file region in netty io_uring. If there is no plan for this currently, we can only abandon this plan, thanks very much. |
If someone implements it I am happy to review the code... I dont have the cycles atm to do it myself |
Hello,Can we have an IoUringChunkedNioFile? I tried it and it doesn't seem difficult. |
hi @dreamlike-ocean I think this one to be a better fit outside Netty, which is just a "network" framework. |
@franz1981 actually FileRegion should do a zero copy (aka sendfile). We just never did it so far... It should be doable as io_uring supports splice. |
yes ,I tried it and it doesn't seem difficult.。 |
+1 for the splice-version because it is more in line of what we currently offer with FileRegion |
I will try it later |
Sure we love PRs |
Hi! I have submitted a pull request for this requirement. Please review it.Check if I have correctly understood this requirement. |
The io_uring transport does not currently support fileRegion, when will fileRegion be supported? We are eager to try iouringFileRegion.
The text was updated successfully, but these errors were encountered: