Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version in pyproject.toml is still 6.0.0 #1969

Open
s-t-e-v-e-n-k opened this issue Jan 10, 2025 · 5 comments
Open

Version in pyproject.toml is still 6.0.0 #1969

s-t-e-v-e-n-k opened this issue Jan 10, 2025 · 5 comments

Comments

@s-t-e-v-e-n-k
Copy link

The version field in pyproject.toml is still set to 6.0.0, which doesn't match the version number either in the GitHub release or on PyPi.

@mjbear
Copy link
Contributor

mjbear commented Jan 10, 2025

The version field in pyproject.toml is still set to 6.0.0, which doesn't match the version number either in the GitHub release or on PyPi.

True enough.

version = "6.0.0"

I have some thoughts on how a check for the version could be added to the GitHub Actions CI/CD process.
(I'm not sure we want to auto-update/edit the pyproject.toml file via GH Actions, but I could look into that too.)

I'm a volunteer, so if the maintainers have further feedback/thoughts I'm game for a discussion. 😀

@s-t-e-v-e-n-k
Copy link
Author

We probably don't need to -- there are plugins for poetry that will take the version number from a file or something like that instead of hardcoding it and having to edit it.

@mjbear
Copy link
Contributor

mjbear commented Jan 13, 2025

Releases are created in GitHub so using that workflow to update the pyproject.toml file could be ideal.

I'll continue to look into this as I have time. Thank you!

@mjbear
Copy link
Contributor

mjbear commented Jan 14, 2025

Releases are created in GitHub so using that workflow to update the pyproject.toml file could be ideal.

I'll continue to look into this as I have time. Thank you!

I have a possible solution for this that I need to run by the ntc-templates maintainers. ✨ 🪄
Maybe I spoke too soon 😐

Update:
My thoughts are to auto-bump the version based on the GH Release.
So far everything I've found online as inspiration has been based on pull requests which is not what we'd want.

What I've found thus far is that it seems once the release event is triggered as created we likely can't interject changes to the content.

@mjbear
Copy link
Contributor

mjbear commented Jan 14, 2025

Update:
It also doesn't seem that we can hook in prior to tag creation either.
I suppose a check could be made on push or PR event (though I don't like that option), because I wouldn't want to burden contributors with is the innards of the pyproject.toml file.

Maybe this is something that just needs handled as manual release steps. Thoughts?
@jmcgill298 @jvanderaa @itdependsnetworks

@mjbear mjbear mentioned this issue Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants