Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the landing page #610

Closed
6 of 7 tasks
Tracked by #59
surchs opened this issue Nov 7, 2023 · 3 comments · Fixed by #621
Closed
6 of 7 tasks
Tracked by #59

Clean up the landing page #610

surchs opened this issue Nov 7, 2023 · 3 comments · Fixed by #621
Assignees

Comments

@surchs
Copy link
Contributor

surchs commented Nov 7, 2023

The tool landing page shows

  • a nice clean "upload" button for the .tsv table
  • a nice clean "upload" button for the .json data dictionary
  • the "preview" textboxes are removed
  • all other functionality is unaffected (e.g. .json button being grey until .tsv is provided, next button ...)
  • Upon successful upload (it didn't crash), some super simple UI element says "all good" or ✔️

We still show previews for the .tsv and the .json.

  • preferred: nice looking table / rendered component
  • also good: a non-editable version of the text field we have now
@surchs surchs added this to Neurobagel Nov 7, 2023
@surchs surchs moved this to Specify - Active in Neurobagel Nov 9, 2023
@surchs surchs changed the title Remove landing page debug views Clean up the landing page Nov 9, 2023
@surchs surchs moved this from Specify - Active to Specify - Done in Neurobagel Nov 9, 2023
@surchs surchs moved this from Specify - Done to Implement - Active in Neurobagel Nov 9, 2023
@surchs surchs self-assigned this Nov 9, 2023
@surchs
Copy link
Contributor Author

surchs commented Nov 9, 2023

For JSON rendering: https://github.com/leezng/vue-json-pretty
For .tsv rendering: https://bootstrap-vue.org/docs/components/table as before

@surchs
Copy link
Contributor Author

surchs commented Nov 9, 2023

Not using https://github.com/leezng/vue-json-pretty anymore, because they don't do deep reactivity: leezng/vue-json-pretty#213 and we kinda need that here. So instead we go with a simple prerendered text.

@surchs surchs moved this from Implement - Active to Implement - Done in Neurobagel Nov 9, 2023
@surchs
Copy link
Contributor Author

surchs commented Nov 9, 2023

I'm also skipping the "everything is great" notification here because that would need a toast and that's a bit much right now

@rmanaem rmanaem moved this from Implement - Done to Review - Active in Neurobagel Nov 10, 2023
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant