Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto-generation of query result examples #368

Closed
6 tasks done
alyssadai opened this issue Nov 22, 2024 · 6 comments · Fixed by #434
Closed
6 tasks done

Update auto-generation of query result examples #368

alyssadai opened this issue Nov 22, 2024 · 6 comments · Fixed by #434
Assignees

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Nov 22, 2024

We need to update the current workflow for auto-generating query result examples, to ensure that the examples are intuitive for a user and represent a typical federated query result structure.

Ideally, we would be able to auto-generate an example that:

  • Represents aggregated and non-aggregated dataset results in the same file = one human-readable result TSV example, one machine-optimized result TSV example (this is what we currently have, but the examples were generated manually)

Steps to implement

  • ensure that neurobagel_examples submodule exists in query tool repo
  • repurpose our f-API success response example (which contains 2 aggregated datasets and 1 non-aggregated dataset) https://github.com/neurobagel/neurobagel_examples/blob/main/api-responses/fapi_query_success_200.json to mock the f-API response to auto-generate the query result TSVs and to avoid having to stand up two separate nodes in the query tool repo
  • create workflow to regenerate query result TSVs using above
    • wf should run:
      • whenever the f-API example outputs in neurobagel_examples is updated
      • whenever the query result TSV format itself changes (e.g., columns renamed)
@alyssadai alyssadai changed the title Revisit format of auto-generated query result examples Update auto-generation of query result examples Dec 3, 2024
@rmanaem rmanaem added the flag:schedule Flag issue that should go on the roadmap or backlog. label Dec 17, 2024
@rmanaem rmanaem moved this to Backlog in Neurobagel Jan 6, 2025
@rmanaem rmanaem removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Jan 6, 2025
@surchs
Copy link
Contributor

surchs commented Jan 6, 2025

This might be a bit complex, so we should

  • think through how to do this automatically and discuss it with the team
  • then implement the automatic generation

@rmanaem
Copy link
Contributor

rmanaem commented Jan 6, 2025

One idea could be to use write an e2e test and mock the response using the f-api success response example save the files as artifact (I think cypress has a setting for this) and then make a PR to the Neurobagel example with the artifacts using the Neurobagel bot.

@rmanaem rmanaem moved this from Backlog to Specify - Active in Neurobagel Jan 7, 2025
@alyssadai
Copy link
Contributor Author

Updated the issue desc with steps to implement. @rmanaem, let me know if the tasks make sense to you!

@rmanaem rmanaem moved this from Specify - Active to Specify - Done in Neurobagel Jan 8, 2025
@rmanaem rmanaem self-assigned this Jan 8, 2025
@rmanaem rmanaem moved this from Specify - Done to Implement - Active in Neurobagel Jan 8, 2025
@surchs
Copy link
Contributor

surchs commented Jan 9, 2025

@alyssadai please provide example of PR in other repo from climate dashboard

@alyssadai
Copy link
Contributor Author

Hey @rmanaem, see this workflow for an example of using the create-pull-request action to create PRs.

Here's an example from the action maintainer on creating PRs in a different target repo (afaict):
peter-evans/create-pull-request#3557 (comment)

@rmanaem rmanaem moved this from Implement - Active to Implement - Done in Neurobagel Jan 10, 2025
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Jan 10, 2025
@alyssadai
Copy link
Contributor Author

See also the newly added sections in the developer docs about using Neurobagel Bot app tokens for multi-repo workflows:

and about the permissions top-level key in workflows:

Our list of PATs has also been updated to indicate which ones have been replaced by the Neurobagel Bot app.

@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review - Done
Development

Successfully merging a pull request may close this issue.

3 participants