Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pdfjs to expose PDF.js highlighting editor #874

Open
nopper opened this issue Dec 20, 2023 · 1 comment
Open

Upgrade pdfjs to expose PDF.js highlighting editor #874

nopper opened this issue Dec 20, 2023 · 1 comment
Labels
dependencies Pull requests that update a dependency file enhancement

Comments

@nopper
Copy link

nopper commented Dec 20, 2023

The new version of pdfjs should support highlighting as additional annotations:

mozilla/pdf.js@1ea6293

It would be great to have this feature shipped in files_pdfviewer. So far the app only expose text, freehand drawing, and image annotations.

Steps to reproduce

  1. Open a PDF in edit mode

Expected behaviour

Allowing the user to add highlighting annotations.

Actual behaviour

Only text, drawing and image insertion are the supported annotations.

Server configuration

Nextcloud version: (see Nextcloud admin page)
Nextcloud Hub 7 (28.0.0)

@hermeneuticlens
Copy link

I second this! Actually, enable all the annotation features pdf.js supports such text highlighting and text insertion.

@joshtrichards joshtrichards added enhancement dependencies Pull requests that update a dependency file labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

No branches or pull requests

3 participants