New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Refill v8 with theme variants for labels #415

Open

nvkelso opened this issue Jul 24, 2017 · 1 comment

Contributor

nvkelso commented Jul 24, 2017 •

edited

Loading

With version 8 of Refill we're updating refill-style but not updating refill-style-more-labels or refill-style-no-labels.

Instead Mapzen.js will need to manually import those via the new label themes.

The text was updated successfully, but these errors were encountered:

Contributor Author

nvkelso commented Jul 24, 2017

It may be possible to list a larger array here to accomplish this:

https://github.com/mapzen/mapzen.js/blob/ff3466315d9b0bf256e5a9b6b9202f22e5fb0a95/src/js/components/basemapStyles.js#L10-L11

  RefillMoreLabels: 'https://mapzen.com/carto/refill-style-more-labels/7/refill-style-more-labels.zip',
  RefillNoLabels: 'https://mapzen.com/carto/refill-style-no-labels/7/refill-style-no-labels.zip',

to (unverified):

  RefillMoreLabels: [ 'https://mapzen.com/carto/refill-style/8/refill-style.zip', 'https://mapzen.com/carto/refill-style/8/themes/label-10.zip' ],
  RefillNoLabels:   [ 'https://mapzen.com/carto/refill-style/8/refill-style.zip', 'https://mapzen.com/carto/refill-style/8/themes/label-0.zip' ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment