Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of lint check files_unchanged is different in 3.1.2 #3422

Open
awgymer opened this issue Jan 24, 2025 · 0 comments
Open

Behaviour of lint check files_unchanged is different in 3.1.2 #3422

awgymer opened this issue Jan 24, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@awgymer
Copy link
Contributor

awgymer commented Jan 24, 2025

Description of the bug

In previous versions of the tools manifest.author was required for the files_unchanged check and this was checked up front and if it wasn't present the test was skipped (source code).

In 3.1.2 we now pull names from either manifest.author or manifest.contributors (source code). However neither of these are checked for up front now (source code).

This can cause an unhandled error to be raised if neither manifest.author or manifest.contributors is present or if they resolve to an empty string (e.g. if contributors do not have a name field set see: pairgenomealign example).

We should either check for the presence of the author/contributors up front or add a check at the point of determination of names to similarly ignore the lint test.

Command used and terminal output

System information

No response

@awgymer awgymer added the bug Something isn't working label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant