From 2da4a675fd278413bee4afbc7c7717f40c5cb93f Mon Sep 17 00:00:00 2001 From: Milan Raj Date: Wed, 29 Jan 2025 11:32:47 -0600 Subject: [PATCH 1/6] Export DiacriticInsensitivePipe, Icon base, and Table SortedColumn types (#2523) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Pull Request ## 🤨 Rationale Found many instances of direct imports to `@ni/nimble-components` in Angular apps because there was not a direct export of `diacriticInsensitiveStringNormalizer` and a few other types. ## 👩‍💻 Implementation - Exposed `diacriticInsensitiveStringNormalizer` from nimble-angular as a pipe named `DiacriticInsensitivePipe` - Passed through the table page object export of `SortedColumn` - Exported the Icon base class ## 🧪 Testing Rely on CI. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --- ...lar-127e0e6a-d1e2-424f-811b-21791d0fe443.json | 7 +++++++ .../pipes/diacritic-insensitive.pipe.ts | 16 ++++++++++++++++ .../nimble-angular/pipes/public-api.ts | 1 + .../tests/diacritic-insensitive.pipe.spec.ts | 8 ++++++++ .../icon-base/nimble-icon-base.directive.ts | 4 +++- .../table/testing/table.pageobject.ts | 4 +++- 6 files changed, 38 insertions(+), 2 deletions(-) create mode 100644 change/@ni-nimble-angular-127e0e6a-d1e2-424f-811b-21791d0fe443.json create mode 100644 packages/angular-workspace/nimble-angular/pipes/diacritic-insensitive.pipe.ts create mode 100644 packages/angular-workspace/nimble-angular/pipes/tests/diacritic-insensitive.pipe.spec.ts diff --git a/change/@ni-nimble-angular-127e0e6a-d1e2-424f-811b-21791d0fe443.json b/change/@ni-nimble-angular-127e0e6a-d1e2-424f-811b-21791d0fe443.json new file mode 100644 index 0000000000..c0c3d00169 --- /dev/null +++ b/change/@ni-nimble-angular-127e0e6a-d1e2-424f-811b-21791d0fe443.json @@ -0,0 +1,7 @@ +{ + "type": "minor", + "comment": "Export DiacriticInsensitivePipe, Icon base, and Table SortedColumn types", + "packageName": "@ni/nimble-angular", + "email": "rajsite@users.noreply.github.com", + "dependentChangeType": "patch" +} diff --git a/packages/angular-workspace/nimble-angular/pipes/diacritic-insensitive.pipe.ts b/packages/angular-workspace/nimble-angular/pipes/diacritic-insensitive.pipe.ts new file mode 100644 index 0000000000..6534184adc --- /dev/null +++ b/packages/angular-workspace/nimble-angular/pipes/diacritic-insensitive.pipe.ts @@ -0,0 +1,16 @@ +import { Pipe, type PipeTransform } from '@angular/core'; +import { diacriticInsensitiveStringNormalizer } from '@ni/nimble-components/dist/esm/utilities/models/string-normalizers'; + +/** + * Generic normalize pipe that removes the accents and special characters. + * This pipe can be used to normalize a string before performing diacritic-insensitive string comparisons. + */ +@Pipe({ + name: 'diacritic-insensitive', + standalone: true +}) +export class DiacriticInsensitivePipe implements PipeTransform { + public transform(value: string): string { + return diacriticInsensitiveStringNormalizer(value); + } +} diff --git a/packages/angular-workspace/nimble-angular/pipes/public-api.ts b/packages/angular-workspace/nimble-angular/pipes/public-api.ts index 8fbe350339..de1a50f5e2 100644 --- a/packages/angular-workspace/nimble-angular/pipes/public-api.ts +++ b/packages/angular-workspace/nimble-angular/pipes/public-api.ts @@ -1,3 +1,4 @@ +export * from './diacritic-insensitive.pipe'; export * from './duration.pipe'; export * from './number-text.pipe'; export { byteUnitScale } from '@ni/nimble-components/dist/esm/utilities/unit-format/unit-scale/byte-unit-scale'; diff --git a/packages/angular-workspace/nimble-angular/pipes/tests/diacritic-insensitive.pipe.spec.ts b/packages/angular-workspace/nimble-angular/pipes/tests/diacritic-insensitive.pipe.spec.ts new file mode 100644 index 0000000000..4030ffbf92 --- /dev/null +++ b/packages/angular-workspace/nimble-angular/pipes/tests/diacritic-insensitive.pipe.spec.ts @@ -0,0 +1,8 @@ +import { DiacriticInsensitivePipe } from '../diacritic-insensitive.pipe'; + +describe('DiacriticInsensitivePipe', () => { + it('can be constructed and used', () => { + const pipe = new DiacriticInsensitivePipe(); + expect(pipe.transform('Français é, è, ê and ë (French characters)')).toBe('francais e, e, e and e (french characters)'); + }); +}); diff --git a/packages/angular-workspace/nimble-angular/src/directives/icon-base/nimble-icon-base.directive.ts b/packages/angular-workspace/nimble-angular/src/directives/icon-base/nimble-icon-base.directive.ts index 10ea111478..06b678996e 100644 --- a/packages/angular-workspace/nimble-angular/src/directives/icon-base/nimble-icon-base.directive.ts +++ b/packages/angular-workspace/nimble-angular/src/directives/icon-base/nimble-icon-base.directive.ts @@ -1,7 +1,9 @@ import { Directive, ElementRef, Input, Renderer2 } from '@angular/core'; -import type { Icon } from '@ni/nimble-components/dist/esm/icon-base'; +import { Icon } from '@ni/nimble-components/dist/esm/icon-base'; import type { IconSeverity } from '@ni/nimble-components/dist/esm/icon-base/types'; +export { Icon }; + /** * Base class for the nimble icon directives */ diff --git a/packages/angular-workspace/nimble-angular/table/testing/table.pageobject.ts b/packages/angular-workspace/nimble-angular/table/testing/table.pageobject.ts index ff4c4f95a8..22fbd320c7 100644 --- a/packages/angular-workspace/nimble-angular/table/testing/table.pageobject.ts +++ b/packages/angular-workspace/nimble-angular/table/testing/table.pageobject.ts @@ -1,7 +1,9 @@ -import { TablePageObject as NimbleComponentsTablePageObject } from '@ni/nimble-components/dist/esm/table/testing/table.pageobject'; +import { TablePageObject as NimbleComponentsTablePageObject, type SortedColumn } from '@ni/nimble-components/dist/esm/table/testing/table.pageobject'; import { waitForUpdatesAsync } from '@ni/nimble-angular'; import type { Table, TableRecord } from '@ni/nimble-angular/table'; +export type { SortedColumn }; + /** * The page object for the `nimble-table` component to provide consistent ways of querying * and interacting with the component during tests. From 92678ee411f37e691e7dcbf788f9ddf8d6f1279e Mon Sep 17 00:00:00 2001 From: rajsite Date: Wed, 29 Jan 2025 11:51:30 -0600 Subject: [PATCH 2/6] applying package updates [skip ci] --- ...ular-127e0e6a-d1e2-424f-811b-21791d0fe443.json | 7 ------- package-lock.json | 2 +- .../nimble-angular/CHANGELOG.json | 15 +++++++++++++++ .../angular-workspace/nimble-angular/CHANGELOG.md | 10 +++++++++- .../angular-workspace/nimble-angular/package.json | 2 +- 5 files changed, 26 insertions(+), 10 deletions(-) delete mode 100644 change/@ni-nimble-angular-127e0e6a-d1e2-424f-811b-21791d0fe443.json diff --git a/change/@ni-nimble-angular-127e0e6a-d1e2-424f-811b-21791d0fe443.json b/change/@ni-nimble-angular-127e0e6a-d1e2-424f-811b-21791d0fe443.json deleted file mode 100644 index c0c3d00169..0000000000 --- a/change/@ni-nimble-angular-127e0e6a-d1e2-424f-811b-21791d0fe443.json +++ /dev/null @@ -1,7 +0,0 @@ -{ - "type": "minor", - "comment": "Export DiacriticInsensitivePipe, Icon base, and Table SortedColumn types", - "packageName": "@ni/nimble-angular", - "email": "rajsite@users.noreply.github.com", - "dependentChangeType": "patch" -} diff --git a/package-lock.json b/package-lock.json index b9786547f0..411c661f17 100644 --- a/package-lock.json +++ b/package-lock.json @@ -28416,7 +28416,7 @@ }, "packages/angular-workspace/nimble-angular": { "name": "@ni/nimble-angular", - "version": "28.8.2", + "version": "28.9.0", "license": "MIT", "dependencies": { "tslib": "^2.2.0" diff --git a/packages/angular-workspace/nimble-angular/CHANGELOG.json b/packages/angular-workspace/nimble-angular/CHANGELOG.json index c4739a1064..0cce115919 100644 --- a/packages/angular-workspace/nimble-angular/CHANGELOG.json +++ b/packages/angular-workspace/nimble-angular/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@ni/nimble-angular", "entries": [ + { + "date": "Wed, 29 Jan 2025 17:51:30 GMT", + "version": "28.9.0", + "tag": "@ni/nimble-angular_v28.9.0", + "comments": { + "minor": [ + { + "author": "rajsite@users.noreply.github.com", + "package": "@ni/nimble-angular", + "commit": "2da4a675fd278413bee4afbc7c7717f40c5cb93f", + "comment": "Export DiacriticInsensitivePipe, Icon base, and Table SortedColumn types" + } + ] + } + }, { "date": "Thu, 16 Jan 2025 23:05:03 GMT", "version": "28.8.2", diff --git a/packages/angular-workspace/nimble-angular/CHANGELOG.md b/packages/angular-workspace/nimble-angular/CHANGELOG.md index 8dcded3945..5876b1f018 100644 --- a/packages/angular-workspace/nimble-angular/CHANGELOG.md +++ b/packages/angular-workspace/nimble-angular/CHANGELOG.md @@ -1,9 +1,17 @@ # Change Log - @ni/nimble-angular - + +## 28.9.0 + +Wed, 29 Jan 2025 17:51:30 GMT + +### Minor changes + +- Export DiacriticInsensitivePipe, Icon base, and Table SortedColumn types ([ni/nimble@2da4a67](https://github.com/ni/nimble/commit/2da4a675fd278413bee4afbc7c7717f40c5cb93f)) + ## 28.8.2 Thu, 16 Jan 2025 23:05:03 GMT diff --git a/packages/angular-workspace/nimble-angular/package.json b/packages/angular-workspace/nimble-angular/package.json index d344f2a128..9dbafbac85 100644 --- a/packages/angular-workspace/nimble-angular/package.json +++ b/packages/angular-workspace/nimble-angular/package.json @@ -1,6 +1,6 @@ { "name": "@ni/nimble-angular", - "version": "28.8.2", + "version": "28.9.0", "description": "Angular components for the NI Nimble Design System", "scripts": { "invoke-publish": "npm run invoke-publish:setup && cd ../dist/nimble-angular && npm publish", From dcd42ac952ba3aec2bbf7f5bbffd091f69e47482 Mon Sep 17 00:00:00 2001 From: mollykreis <20542556+mollykreis@users.noreply.github.com> Date: Wed, 29 Jan 2025 12:10:39 -0600 Subject: [PATCH 3/6] Allow an item in the toolbar to lose focus by clicking the toolbar itself (#2521) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Pull Request ## 🤨 Rationale Resolves #2494 ## 👩‍💻 Implementation Removed `delgatesFocus: true` on the toolbar so that clicking on an empty space within the toolbar will cause the currently focused item to lose focus. Note: The use case described in the referenced issue may still be a bit problematic given all the editable fields (date pickers, numerics, etc) because the user may expect to use the left/right arrow keys to navigate within that component, but the toolbar will handle the key event first and move focus to a different item in the keyboard. That behavior is not affected in any way by this change. ## 🧪 Testing Manually tested with a numeric field and text field in the toolbar. ## ✅ Checklist - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: Milan Raj --- ...le-components-66a1a299-08a4-495c-9750-85902fe5413f.json | 7 +++++++ packages/nimble-components/src/toolbar/index.ts | 5 +---- 2 files changed, 8 insertions(+), 4 deletions(-) create mode 100644 change/@ni-nimble-components-66a1a299-08a4-495c-9750-85902fe5413f.json diff --git a/change/@ni-nimble-components-66a1a299-08a4-495c-9750-85902fe5413f.json b/change/@ni-nimble-components-66a1a299-08a4-495c-9750-85902fe5413f.json new file mode 100644 index 0000000000..6ecbb1c76c --- /dev/null +++ b/change/@ni-nimble-components-66a1a299-08a4-495c-9750-85902fe5413f.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Allow an item in the toolbar to lose focus by clicking the toolbar itself", + "packageName": "@ni/nimble-components", + "email": "20542556+mollykreis@users.noreply.github.com", + "dependentChangeType": "patch" +} diff --git a/packages/nimble-components/src/toolbar/index.ts b/packages/nimble-components/src/toolbar/index.ts index 66023ac3c5..2a61ed7874 100644 --- a/packages/nimble-components/src/toolbar/index.ts +++ b/packages/nimble-components/src/toolbar/index.ts @@ -21,10 +21,7 @@ const nimbleToolbar = Toolbar.compose({ baseName: 'toolbar', baseClass: FoundationToolbar, template, - styles, - shadowOptions: { - delegatesFocus: true - } + styles }); DesignSystem.getOrCreate().withPrefix('nimble').register(nimbleToolbar()); From 52caaabfa9c595f1909d1bb374aae3d228c4d172 Mon Sep 17 00:00:00 2001 From: rajsite Date: Wed, 29 Jan 2025 12:28:30 -0600 Subject: [PATCH 4/6] applying package updates [skip ci] --- ...-66a1a299-08a4-495c-9750-85902fe5413f.json | 7 ------ package-lock.json | 22 +++++++++---------- .../nimble-angular/CHANGELOG.json | 15 +++++++++++++ .../nimble-angular/CHANGELOG.md | 10 ++++++++- .../nimble-angular/package.json | 4 ++-- .../spright-angular/CHANGELOG.json | 15 +++++++++++++ .../spright-angular/CHANGELOG.md | 10 ++++++++- .../spright-angular/package.json | 4 ++-- .../NimbleBlazor/CHANGELOG.json | 15 +++++++++++++ .../NimbleBlazor/CHANGELOG.md | 10 ++++++++- .../NimbleBlazor/package.json | 4 ++-- .../SprightBlazor/CHANGELOG.json | 15 +++++++++++++ .../SprightBlazor/CHANGELOG.md | 10 ++++++++- .../SprightBlazor/package.json | 4 ++-- packages/nimble-components/CHANGELOG.json | 15 +++++++++++++ packages/nimble-components/CHANGELOG.md | 10 ++++++++- packages/nimble-components/package.json | 2 +- packages/spright-components/CHANGELOG.json | 15 +++++++++++++ packages/spright-components/CHANGELOG.md | 10 ++++++++- packages/spright-components/package.json | 4 ++-- 20 files changed, 166 insertions(+), 35 deletions(-) delete mode 100644 change/@ni-nimble-components-66a1a299-08a4-495c-9750-85902fe5413f.json diff --git a/change/@ni-nimble-components-66a1a299-08a4-495c-9750-85902fe5413f.json b/change/@ni-nimble-components-66a1a299-08a4-495c-9750-85902fe5413f.json deleted file mode 100644 index 6ecbb1c76c..0000000000 --- a/change/@ni-nimble-components-66a1a299-08a4-495c-9750-85902fe5413f.json +++ /dev/null @@ -1,7 +0,0 @@ -{ - "type": "patch", - "comment": "Allow an item in the toolbar to lose focus by clicking the toolbar itself", - "packageName": "@ni/nimble-components", - "email": "20542556+mollykreis@users.noreply.github.com", - "dependentChangeType": "patch" -} diff --git a/package-lock.json b/package-lock.json index 411c661f17..9bd6381fef 100644 --- a/package-lock.json +++ b/package-lock.json @@ -28416,7 +28416,7 @@ }, "packages/angular-workspace/nimble-angular": { "name": "@ni/nimble-angular", - "version": "28.9.0", + "version": "28.9.1", "license": "MIT", "dependencies": { "tslib": "^2.2.0" @@ -28427,12 +28427,12 @@ "@angular/forms": "^17.3.12", "@angular/localize": "^17.3.12", "@angular/router": "^17.3.12", - "@ni/nimble-components": "^32.11.2" + "@ni/nimble-components": "^32.11.3" } }, "packages/angular-workspace/spright-angular": { "name": "@ni/spright-angular", - "version": "5.3.6", + "version": "5.3.7", "license": "MIT", "dependencies": { "tslib": "^2.2.0" @@ -28440,7 +28440,7 @@ "peerDependencies": { "@angular/common": "^17.3.12", "@angular/core": "^17.3.12", - "@ni/spright-components": "^4.3.7" + "@ni/spright-components": "^4.3.8" } }, "packages/blazor-workspace": { @@ -28461,10 +28461,10 @@ }, "packages/blazor-workspace/NimbleBlazor": { "name": "@ni/nimble-blazor", - "version": "19.4.2", + "version": "19.4.3", "license": "MIT", "peerDependencies": { - "@ni/nimble-components": "^32.11.2", + "@ni/nimble-components": "^32.11.3", "@ni/nimble-tokens": "^8.6.0", "cross-env": "^7.0.3", "rimraf": "^6.0.0" @@ -28535,10 +28535,10 @@ }, "packages/blazor-workspace/SprightBlazor": { "name": "@ni/spright-blazor", - "version": "3.2.6", + "version": "3.2.7", "license": "MIT", "peerDependencies": { - "@ni/spright-components": "^4.3.7", + "@ni/spright-components": "^4.3.8", "cross-env": "^7.0.3", "rimraf": "^6.0.0" } @@ -28573,7 +28573,7 @@ }, "packages/nimble-components": { "name": "@ni/nimble-components", - "version": "32.11.2", + "version": "32.11.3", "license": "MIT", "dependencies": { "@microsoft/fast-colors": "^5.3.1", @@ -28691,12 +28691,12 @@ }, "packages/spright-components": { "name": "@ni/spright-components", - "version": "4.3.7", + "version": "4.3.8", "license": "MIT", "dependencies": { "@microsoft/fast-element": "^1.14.0", "@microsoft/fast-foundation": "^2.50.0", - "@ni/nimble-components": "^32.11.2", + "@ni/nimble-components": "^32.11.3", "tslib": "^2.2.0" }, "devDependencies": { diff --git a/packages/angular-workspace/nimble-angular/CHANGELOG.json b/packages/angular-workspace/nimble-angular/CHANGELOG.json index 0cce115919..e6430f9ae2 100644 --- a/packages/angular-workspace/nimble-angular/CHANGELOG.json +++ b/packages/angular-workspace/nimble-angular/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@ni/nimble-angular", "entries": [ + { + "date": "Wed, 29 Jan 2025 18:28:30 GMT", + "version": "28.9.1", + "tag": "@ni/nimble-angular_v28.9.1", + "comments": { + "patch": [ + { + "author": "beachball", + "package": "@ni/nimble-angular", + "comment": "Bump @ni/nimble-components to v32.11.3", + "commit": "not available" + } + ] + } + }, { "date": "Wed, 29 Jan 2025 17:51:30 GMT", "version": "28.9.0", diff --git a/packages/angular-workspace/nimble-angular/CHANGELOG.md b/packages/angular-workspace/nimble-angular/CHANGELOG.md index 5876b1f018..b1b0e08175 100644 --- a/packages/angular-workspace/nimble-angular/CHANGELOG.md +++ b/packages/angular-workspace/nimble-angular/CHANGELOG.md @@ -1,9 +1,17 @@ # Change Log - @ni/nimble-angular - + +## 28.9.1 + +Wed, 29 Jan 2025 18:28:30 GMT + +### Patches + +- Bump @ni/nimble-components to v32.11.3 + ## 28.9.0 Wed, 29 Jan 2025 17:51:30 GMT diff --git a/packages/angular-workspace/nimble-angular/package.json b/packages/angular-workspace/nimble-angular/package.json index 9dbafbac85..304620c980 100644 --- a/packages/angular-workspace/nimble-angular/package.json +++ b/packages/angular-workspace/nimble-angular/package.json @@ -1,6 +1,6 @@ { "name": "@ni/nimble-angular", - "version": "28.9.0", + "version": "28.9.1", "description": "Angular components for the NI Nimble Design System", "scripts": { "invoke-publish": "npm run invoke-publish:setup && cd ../dist/nimble-angular && npm publish", @@ -32,7 +32,7 @@ "@angular/forms": "^17.3.12", "@angular/localize": "^17.3.12", "@angular/router": "^17.3.12", - "@ni/nimble-components": "^32.11.2" + "@ni/nimble-components": "^32.11.3" }, "dependencies": { "tslib": "^2.2.0" diff --git a/packages/angular-workspace/spright-angular/CHANGELOG.json b/packages/angular-workspace/spright-angular/CHANGELOG.json index 9a227c5321..a4bf94d0c5 100644 --- a/packages/angular-workspace/spright-angular/CHANGELOG.json +++ b/packages/angular-workspace/spright-angular/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@ni/spright-angular", "entries": [ + { + "date": "Wed, 29 Jan 2025 18:28:30 GMT", + "version": "5.3.7", + "tag": "@ni/spright-angular_v5.3.7", + "comments": { + "patch": [ + { + "author": "beachball", + "package": "@ni/spright-angular", + "comment": "Bump @ni/spright-components to v4.3.8", + "commit": "not available" + } + ] + } + }, { "date": "Thu, 16 Jan 2025 23:05:03 GMT", "version": "5.3.6", diff --git a/packages/angular-workspace/spright-angular/CHANGELOG.md b/packages/angular-workspace/spright-angular/CHANGELOG.md index bc1bb133f1..892cd5f958 100644 --- a/packages/angular-workspace/spright-angular/CHANGELOG.md +++ b/packages/angular-workspace/spright-angular/CHANGELOG.md @@ -1,9 +1,17 @@ # Change Log - @ni/spright-angular - + +## 5.3.7 + +Wed, 29 Jan 2025 18:28:30 GMT + +### Patches + +- Bump @ni/spright-components to v4.3.8 + ## 5.3.6 Thu, 16 Jan 2025 23:05:03 GMT diff --git a/packages/angular-workspace/spright-angular/package.json b/packages/angular-workspace/spright-angular/package.json index b86bc8eff6..948bb14cae 100644 --- a/packages/angular-workspace/spright-angular/package.json +++ b/packages/angular-workspace/spright-angular/package.json @@ -1,6 +1,6 @@ { "name": "@ni/spright-angular", - "version": "5.3.6", + "version": "5.3.7", "description": "Angular components for NI Spright", "scripts": { "invoke-publish": "npm run invoke-publish:setup && cd ../dist/spright-angular && npm publish", @@ -24,7 +24,7 @@ "peerDependencies": { "@angular/common": "^17.3.12", "@angular/core": "^17.3.12", - "@ni/spright-components": "^4.3.7" + "@ni/spright-components": "^4.3.8" }, "dependencies": { "tslib": "^2.2.0" diff --git a/packages/blazor-workspace/NimbleBlazor/CHANGELOG.json b/packages/blazor-workspace/NimbleBlazor/CHANGELOG.json index 6a77c86156..5fb8cfac4f 100644 --- a/packages/blazor-workspace/NimbleBlazor/CHANGELOG.json +++ b/packages/blazor-workspace/NimbleBlazor/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@ni/nimble-blazor", "entries": [ + { + "date": "Wed, 29 Jan 2025 18:28:30 GMT", + "version": "19.4.3", + "tag": "@ni/nimble-blazor_v19.4.3", + "comments": { + "patch": [ + { + "author": "beachball", + "package": "@ni/nimble-blazor", + "comment": "Bump @ni/nimble-components to v32.11.3", + "commit": "not available" + } + ] + } + }, { "date": "Thu, 16 Jan 2025 23:05:03 GMT", "version": "19.4.2", diff --git a/packages/blazor-workspace/NimbleBlazor/CHANGELOG.md b/packages/blazor-workspace/NimbleBlazor/CHANGELOG.md index 57ace08eb1..353269faa6 100644 --- a/packages/blazor-workspace/NimbleBlazor/CHANGELOG.md +++ b/packages/blazor-workspace/NimbleBlazor/CHANGELOG.md @@ -1,9 +1,17 @@ # Change Log - @ni/nimble-blazor - + +## 19.4.3 + +Wed, 29 Jan 2025 18:28:30 GMT + +### Patches + +- Bump @ni/nimble-components to v32.11.3 + ## 19.4.2 Thu, 16 Jan 2025 23:05:03 GMT diff --git a/packages/blazor-workspace/NimbleBlazor/package.json b/packages/blazor-workspace/NimbleBlazor/package.json index 74fdeebb1c..223fe4f2ce 100644 --- a/packages/blazor-workspace/NimbleBlazor/package.json +++ b/packages/blazor-workspace/NimbleBlazor/package.json @@ -1,6 +1,6 @@ { "name": "@ni/nimble-blazor", - "version": "19.4.2", + "version": "19.4.3", "description": "Blazor components for the NI Nimble Design System", "scripts": { "pack": "cross-env-shell dotnet pack -c Release -p:PackageVersion=$npm_package_version --output ../dist", @@ -25,7 +25,7 @@ "!*" ], "peerDependencies": { - "@ni/nimble-components": "^32.11.2", + "@ni/nimble-components": "^32.11.3", "@ni/nimble-tokens": "^8.6.0", "cross-env": "^7.0.3", "rimraf": "^6.0.0" diff --git a/packages/blazor-workspace/SprightBlazor/CHANGELOG.json b/packages/blazor-workspace/SprightBlazor/CHANGELOG.json index a4d2f00290..fd89a08908 100644 --- a/packages/blazor-workspace/SprightBlazor/CHANGELOG.json +++ b/packages/blazor-workspace/SprightBlazor/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@ni/spright-blazor", "entries": [ + { + "date": "Wed, 29 Jan 2025 18:28:30 GMT", + "version": "3.2.7", + "tag": "@ni/spright-blazor_v3.2.7", + "comments": { + "patch": [ + { + "author": "beachball", + "package": "@ni/spright-blazor", + "comment": "Bump @ni/spright-components to v4.3.8", + "commit": "not available" + } + ] + } + }, { "date": "Thu, 16 Jan 2025 23:05:03 GMT", "version": "3.2.6", diff --git a/packages/blazor-workspace/SprightBlazor/CHANGELOG.md b/packages/blazor-workspace/SprightBlazor/CHANGELOG.md index 0e56dc4adc..d3d23b1772 100644 --- a/packages/blazor-workspace/SprightBlazor/CHANGELOG.md +++ b/packages/blazor-workspace/SprightBlazor/CHANGELOG.md @@ -1,9 +1,17 @@ # Change Log - @ni/spright-blazor - + +## 3.2.7 + +Wed, 29 Jan 2025 18:28:30 GMT + +### Patches + +- Bump @ni/spright-components to v4.3.8 + ## 3.2.6 Thu, 16 Jan 2025 23:05:03 GMT diff --git a/packages/blazor-workspace/SprightBlazor/package.json b/packages/blazor-workspace/SprightBlazor/package.json index df17f2b6c6..63a38aec20 100644 --- a/packages/blazor-workspace/SprightBlazor/package.json +++ b/packages/blazor-workspace/SprightBlazor/package.json @@ -1,6 +1,6 @@ { "name": "@ni/spright-blazor", - "version": "3.2.6", + "version": "3.2.7", "description": "Blazor components for Spright", "scripts": { "pack": "cross-env-shell dotnet pack -c Release -p:PackageVersion=$npm_package_version --output ../dist", @@ -25,7 +25,7 @@ "!*" ], "peerDependencies": { - "@ni/spright-components": "^4.3.7", + "@ni/spright-components": "^4.3.8", "cross-env": "^7.0.3", "rimraf": "^6.0.0" } diff --git a/packages/nimble-components/CHANGELOG.json b/packages/nimble-components/CHANGELOG.json index 0113639970..4a636177bb 100644 --- a/packages/nimble-components/CHANGELOG.json +++ b/packages/nimble-components/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@ni/nimble-components", "entries": [ + { + "date": "Wed, 29 Jan 2025 18:28:29 GMT", + "version": "32.11.3", + "tag": "@ni/nimble-components_v32.11.3", + "comments": { + "patch": [ + { + "author": "20542556+mollykreis@users.noreply.github.com", + "package": "@ni/nimble-components", + "commit": "dcd42ac952ba3aec2bbf7f5bbffd091f69e47482", + "comment": "Allow an item in the toolbar to lose focus by clicking the toolbar itself" + } + ] + } + }, { "date": "Thu, 16 Jan 2025 23:05:03 GMT", "version": "32.11.2", diff --git a/packages/nimble-components/CHANGELOG.md b/packages/nimble-components/CHANGELOG.md index d28d08d284..f222ef6ba9 100644 --- a/packages/nimble-components/CHANGELOG.md +++ b/packages/nimble-components/CHANGELOG.md @@ -1,9 +1,17 @@ # Change Log - @ni/nimble-components - + +## 32.11.3 + +Wed, 29 Jan 2025 18:28:29 GMT + +### Patches + +- Allow an item in the toolbar to lose focus by clicking the toolbar itself ([ni/nimble@dcd42ac](https://github.com/ni/nimble/commit/dcd42ac952ba3aec2bbf7f5bbffd091f69e47482)) + ## 32.11.2 Thu, 16 Jan 2025 23:05:03 GMT diff --git a/packages/nimble-components/package.json b/packages/nimble-components/package.json index 6162e31757..0c32f65833 100644 --- a/packages/nimble-components/package.json +++ b/packages/nimble-components/package.json @@ -1,6 +1,6 @@ { "name": "@ni/nimble-components", - "version": "32.11.2", + "version": "32.11.3", "description": "Styled web components for the NI Nimble Design System", "scripts": { "build": "npm run generate-icons && npm run generate-workers && npm run build-components && npm run bundle-components && npm run generate-scss", diff --git a/packages/spright-components/CHANGELOG.json b/packages/spright-components/CHANGELOG.json index 0a326cec0d..9d82b2f7ac 100644 --- a/packages/spright-components/CHANGELOG.json +++ b/packages/spright-components/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@ni/spright-components", "entries": [ + { + "date": "Wed, 29 Jan 2025 18:28:30 GMT", + "version": "4.3.8", + "tag": "@ni/spright-components_v4.3.8", + "comments": { + "patch": [ + { + "author": "beachball", + "package": "@ni/spright-components", + "comment": "Bump @ni/nimble-components to v32.11.3", + "commit": "not available" + } + ] + } + }, { "date": "Thu, 16 Jan 2025 23:05:03 GMT", "version": "4.3.7", diff --git a/packages/spright-components/CHANGELOG.md b/packages/spright-components/CHANGELOG.md index d2deaf4bcc..51788a03a8 100644 --- a/packages/spright-components/CHANGELOG.md +++ b/packages/spright-components/CHANGELOG.md @@ -1,9 +1,17 @@ # Change Log - @ni/spright-components - + +## 4.3.8 + +Wed, 29 Jan 2025 18:28:30 GMT + +### Patches + +- Bump @ni/nimble-components to v32.11.3 + ## 4.3.7 Thu, 16 Jan 2025 23:05:03 GMT diff --git a/packages/spright-components/package.json b/packages/spright-components/package.json index 2e73967a9a..400b1cfedd 100644 --- a/packages/spright-components/package.json +++ b/packages/spright-components/package.json @@ -1,6 +1,6 @@ { "name": "@ni/spright-components", - "version": "4.3.7", + "version": "4.3.8", "description": "NI Spright Components", "scripts": { "build": "npm run build-components && npm run bundle-components", @@ -50,7 +50,7 @@ "dependencies": { "@microsoft/fast-element": "^1.14.0", "@microsoft/fast-foundation": "^2.50.0", - "@ni/nimble-components": "^32.11.2", + "@ni/nimble-components": "^32.11.3", "tslib": "^2.2.0" }, "devDependencies": { From 6040116d40c8cebc6418f5beaa98cc7eaf236e0c Mon Sep 17 00:00:00 2001 From: Milan Raj Date: Wed, 29 Jan 2025 14:28:21 -0600 Subject: [PATCH 5/6] Disable Firefox in concurrent test runs for CI (#2524) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Pull Request ## 🤨 Rationale Firefox test execution on CI continues to be intermittent for a non-specific set of tests, see: [AzDo 2995347](https://ni.visualstudio.com/DevCentral/_workitems/edit/2995347). Previous Firefox intermittency analysis: https://github.com/ni/nimble/issues/2456 ## 👩‍💻 Implementation Disabled firefox execution in the `test-concurrent` command leveraged on CI. ## 🧪 Testing Rely on CI. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --- ...le-components-5ea84983-4985-4423-9b3c-0cec94b65700.json | 7 +++++++ packages/nimble-components/package.json | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 change/@ni-nimble-components-5ea84983-4985-4423-9b3c-0cec94b65700.json diff --git a/change/@ni-nimble-components-5ea84983-4985-4423-9b3c-0cec94b65700.json b/change/@ni-nimble-components-5ea84983-4985-4423-9b3c-0cec94b65700.json new file mode 100644 index 0000000000..a3bc25a5de --- /dev/null +++ b/change/@ni-nimble-components-5ea84983-4985-4423-9b3c-0cec94b65700.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Remove firefox from concurrent testing", + "packageName": "@ni/nimble-components", + "email": "rajsite@users.noreply.github.com", + "dependentChangeType": "none" +} diff --git a/packages/nimble-components/package.json b/packages/nimble-components/package.json index 0c32f65833..fa5f2e99c1 100644 --- a/packages/nimble-components/package.json +++ b/packages/nimble-components/package.json @@ -41,7 +41,7 @@ "test-webkit:debugger": "karma start karma.conf.js --browsers=WebkitDebugging --skip-tags SkipWebkit", "test-webkit:watch": "karma start karma.conf.headless.js --browsers=WebkitHeadless --skip-tags SkipWebkit --watch-extensions js", "test-webkit": "karma start karma.conf.headless.js --browsers=WebkitHeadless --single-run --skip-tags SkipWebkit", - "test-concurrent": "concurrently --pad-prefix --timings --group \"npm:test-chrome\" \"npm:test-firefox\" \"npm:test-webkit\"" + "test-concurrent": "concurrently --pad-prefix --timings --group \"npm:test-chrome\" \"npm:test-webkit\"" }, "repository": { "type": "git", From e987724a828668b1902efdc82aeb6fd57a086cdd Mon Sep 17 00:00:00 2001 From: rajsite Date: Wed, 29 Jan 2025 14:44:10 -0600 Subject: [PATCH 6/6] applying package updates [skip ci] --- ...ents-5ea84983-4985-4423-9b3c-0cec94b65700.json | 7 ------- packages/nimble-components/CHANGELOG.json | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 7 deletions(-) delete mode 100644 change/@ni-nimble-components-5ea84983-4985-4423-9b3c-0cec94b65700.json diff --git a/change/@ni-nimble-components-5ea84983-4985-4423-9b3c-0cec94b65700.json b/change/@ni-nimble-components-5ea84983-4985-4423-9b3c-0cec94b65700.json deleted file mode 100644 index a3bc25a5de..0000000000 --- a/change/@ni-nimble-components-5ea84983-4985-4423-9b3c-0cec94b65700.json +++ /dev/null @@ -1,7 +0,0 @@ -{ - "type": "none", - "comment": "Remove firefox from concurrent testing", - "packageName": "@ni/nimble-components", - "email": "rajsite@users.noreply.github.com", - "dependentChangeType": "none" -} diff --git a/packages/nimble-components/CHANGELOG.json b/packages/nimble-components/CHANGELOG.json index 4a636177bb..c6c3dcd49c 100644 --- a/packages/nimble-components/CHANGELOG.json +++ b/packages/nimble-components/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@ni/nimble-components", "entries": [ + { + "date": "Wed, 29 Jan 2025 20:44:10 GMT", + "version": "32.11.3", + "tag": "@ni/nimble-components_v32.11.3", + "comments": { + "none": [ + { + "author": "rajsite@users.noreply.github.com", + "package": "@ni/nimble-components", + "commit": "6040116d40c8cebc6418f5beaa98cc7eaf236e0c", + "comment": "Remove firefox from concurrent testing" + } + ] + } + }, { "date": "Wed, 29 Jan 2025 18:28:29 GMT", "version": "32.11.3",