Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDS location #5

Open
phebepalmer opened this issue Jul 5, 2020 · 1 comment
Open

IDS location #5

phebepalmer opened this issue Jul 5, 2020 · 1 comment

Comments

@phebepalmer
Copy link
Collaborator

I currently have all of the datasets in the package set to contain a variable called ids, which provides a unique identifier for each headline in the dataset. These are used for a variety of helper functions, namely those relying on the tidytext package. I am not sure if a better approach would be to simply add these ids within the functions that need them, or to contain them in the datasets themselves. I could see a few scenarios where it might be useful to students to include them, but I feel like it might be a bit confusing.

What would you prefer? @nicholasjhorton

@nicholasjhorton
Copy link
Owner

Can we discuss this? I'm not 100% confident about the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants