Some of the single quotes in the synonyms column of the compound reference file are not escaped. #337
-
Example CID: 5337997
|
Beta Was this translation helpful? Give feedback.
Replies: 7 comments 1 reply
-
Replicated; fixing and pushing an update, stand by |
Beta Was this translation helpful? Give feedback.
-
This issue has now tested as "fixed" -- marking "answered," but please reopen and report if you find otherwise. Ontology files and the submission prep script have all been updated and published here: please overwrite local copies and try again. Note: the master C2M2 JSON schema has also updated (to match previous development schema): it is here and an up-to-date copy needs to be included with submissions during prep with the script. |
Beta Was this translation helpful? Give feedback.
-
Sorry -- we had other issues with single quotes being inappropriate delimiters for JSON strings, which was fixed, and I rolled my response above into the fix for that -- but what you quote above is a spec-compliant JSON string array, and none of our software is going to have any problem with it. Single quotes are inconsistently escaped within the double-quoted names, but this is irrelevant: the only characters JSON requires escape sequences for inside double-quoted strings are the double-quote characters themselves. All other escape-like sequences are ignored by spec-compliant software and treated as string literals. Note also that the single-quote-escape inconsistency is something we imported directly from the PubChem labels and is not an artifact of our processing. See this page, section 3.4.2, and search for a backslash: what you quote above, with one |
Beta Was this translation helpful? Give feedback.
-
[just so i can try to avoid falling on my face again this week -- i'm correct in thinking that CastError was not generated by CFDE software, right? if i'm wrong and it was, please let me know which bit so i can go yell at it] |
Beta Was this translation helpful? Give feedback.
-
Today I get this cfde-submit error which seems relevant to this discussion:
|
Beta Was this translation helpful? Give feedback.
-
@jeremyjyang i'm moving this last issue to the helpdesk; as soon as i can figure out how to add you as a watcher, you should get an email @jeevangelista after some further reading, i think i have to tweak one more thing to process these [censored] backslashes properly; stand by for another fix attempt, and sorry for confusion in earlier replies |
Beta Was this translation helpful? Give feedback.
-
[FYI: I tried to port this to JIRA and I think I failed, but if anyone can actually access the ticket here, please let me know: it would help with internal access-management debugging] @jeremyjyang @jeevangelista Please download the latest prep script, compound and substance tables from here: if either of your respective issues remains unsolved by this update, please attach your submission TSVs [somewhere on github I can get to?] for immediate followup (and email [email protected] so I can fold further developments more effectively into our issue tracker). PS. Also be sure to grab the latest JSON schema file for inclusion with your submission; we removed some uniqueness constraints (relevant to @jeremyjyang at minimum) on 4/8. |
Beta Was this translation helpful? Give feedback.
[FYI: I tried to port this to JIRA and I think I failed, but if anyone can actually access the ticket here, please let me know: it would help with internal access-management debugging]
@jeremyjyang @jeevangelista Please download the latest prep script, compound and substance tables from here: if either of your respective issues remains unsolved by this update, please attach your submission TSVs [somewhere on github I can get to?] for immediate followup (and email [email protected] so I can fold further developments more effectively into our issue tracker).
PS. Also be sure to grab the latest JSON schema file for inclusion with your submission; we removed some uniqueness constrain…