You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this case, we have edges that connect the contents of temporal containers to their containers, to an abstractive container. This breaks layout functionality for several reasons:
layout.layoutTemporalContainers() will cause the edge to shift downwards when the temporal container is expanded, no longer connecting to the rim of the container.
layout.layoutGraphRecurse() will break, as the abstractive container will be laid out, but it will contain edges connecting itself to its children, which causes ELK to raise an exception.
Required fixes:
In layout.layoutTemporalContainers(), when edges are being shifted, check if the edge connects to the temporal container output or input port, and freeze its appropriate endpoint.
Our stopgap fix (already implemented) is to clear the edge list of an abstractive container if it contains temporal containers. This causes no error to be raised, but leads to some ugly-looking lines and is likely not robust. I'm not sure what the best solution is here.
The text was updated successfully, but these errors were encountered:
In this case, we have edges that connect the contents of temporal containers to their containers, to an abstractive container. This breaks layout functionality for several reasons:
layout.layoutTemporalContainers()
will cause the edge to shift downwards when the temporal container is expanded, no longer connecting to the rim of the container.layout.layoutGraphRecurse()
will break, as the abstractive container will be laid out, but it will contain edges connecting itself to its children, which causes ELK to raise an exception.Required fixes:
layout.layoutTemporalContainers()
, when edges are being shifted, check if the edge connects to the temporal container output or input port, and freeze its appropriate endpoint.The text was updated successfully, but these errors were encountered: