From 2edc66df8e76c555eebe97fcaf2a15eab1818a31 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Sun, 6 Oct 2024 20:00:13 +0200 Subject: [PATCH] STY: Apply ruff/Perflint rule PERF401 PERF401 Use a list comprehension to create a transformed list --- nipype/pipeline/engine/utils.py | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/nipype/pipeline/engine/utils.py b/nipype/pipeline/engine/utils.py index 5695526550..c5bc83c832 100644 --- a/nipype/pipeline/engine/utils.py +++ b/nipype/pipeline/engine/utils.py @@ -1479,19 +1479,21 @@ def clean_working_directory( needed_files = temp logger.debug("Needed files: %s", ";".join(needed_files)) logger.debug("Needed dirs: %s", ";".join(needed_dirs)) - files2remove = [] if str2bool(config["execution"]["remove_unnecessary_outputs"]): - for f in walk_files(cwd): - if f not in needed_files and not f.startswith(tuple(needed_dirs)): - files2remove.append(f) + files2remove = [ + f + for f in walk_files(cwd) + if f not in needed_files and not f.startswith(tuple(needed_dirs)) + ] + elif not str2bool(config["execution"]["keep_inputs"]): + input_files = { + path for path, type in walk_outputs(inputs.trait_get()) if type == "f" + } + files2remove = [ + f for f in walk_files(cwd) if f in input_files and f not in needed_files + ] else: - if not str2bool(config["execution"]["keep_inputs"]): - input_files = { - path for path, type in walk_outputs(inputs.trait_get()) if type == "f" - } - files2remove.extend( - f for f in walk_files(cwd) if f in input_files and f not in needed_files - ) + files2remove = [] logger.debug("Removing files: %s", ";".join(files2remove)) for f in files2remove: os.remove(f)