Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: use containers/initContainers definition as you wish (list or dict) #35

Open
GRomR1 opened this issue Nov 25, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@GRomR1
Copy link
Contributor

GRomR1 commented Nov 25, 2022

I would like to use both variants in my values.

The first one (as it is) supports only this definition:

deployments:
  api:
    containers:
    - name: container-name
      image: registry/image

But I think it is possible to use this definition too.

deployments:
  api:
    containers:
      container-name:
        image: registry/image

The function kindIs can help to make it (see the example here).

I can create an example and code this feature. But after this PR #31 was merged. Also would like to complete discussion about License (because it's limit me) - #34

@randreev1321 randreev1321 self-assigned this Feb 16, 2023
@randreev1321 randreev1321 added the enhancement New feature or request label Feb 16, 2023
@randreev1321
Copy link
Collaborator

Hi, @GRomR1.

I like your idea. Will wait your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants