Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zubr isn't bundled with PHP #116

Open
nkkollaw opened this issue Aug 8, 2017 · 4 comments
Open

Zubr isn't bundled with PHP #116

nkkollaw opened this issue Aug 8, 2017 · 4 comments

Comments

@nkkollaw
Copy link
Owner

nkkollaw commented Aug 8, 2017

I don't know if GitHub offers a better tool for random discussions, but I thought I'd open a random thread so that we can talk about whatever at hand unless we actually do end up using Slack.

@nkkollaw
Copy link
Owner Author

nkkollaw commented Aug 8, 2017

@ddziaduch : would it make any sense if I added functions, and you helped me out building tests?

They're not my forte (just yet) :-/

We have many functions to cover, and while your work has been awesome, we have to find some way to speed it up or we'll never reach version 1.0 (there are potentially 1000s of functions).

I will start thinking about writing a tool that let us sort out functions that are already OK with functions that need checking.

Also, should I try to recruit more people on Reddit?

@ddziaduch
Copy link
Contributor

Sure thing, I can do tests

@nkkollaw
Copy link
Owner Author

nkkollaw commented Aug 9, 2017

I looked at it last night.

There's this project called Locutus that has already built tests for their project: https://github.com/kvz/locutus, tests are here: https://github.com/kvz/locutus/tree/master/test/languages/php

I want to create a tool to extract and convert their tests to PHP so that we don't have to build them from scratch, but merely check them

I'll start working on this tool ASAP—even tomorrow.

In the meantime I would suggest we don't add any code. I'll also create some issues to keep track of all this and to explain better.

Have faith!!! :-)

@nkkollaw
Copy link
Owner Author

...I used Zubr today for the first time.

I must say that it's pretty awesome.

@nkkollaw nkkollaw reopened this Aug 13, 2017
@nkkollaw nkkollaw changed the title Zubr is not bundled with PHP Zubr isn't bundled with PHP Aug 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants