-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate node in subsetting #129
Comments
This issue is a results of this section of the code: OCSMesh/ocsmesh/cli/subset_n_combine.py Lines 630 to 633 in 0563a79
Here one layer from each mesh (hi and low-res) are taken - in addition to the clipped section by the clipper polygon and then added to the last iteration seam polygon (which doesn't have duplicate). This OCSMesh/ocsmesh/cli/subset_n_combine.py Lines 226 to 227 in 0563a79
def debug(poly):
from shapely import get_coordinates, points
gdf = gpd.GeoDataFrame(geometry=[poly]).explode()
gdf = gdf[gdf.intersects(points(
[842651.955858, 3.983695e+06] # Point in UTM17 from duplicate issue
).buffer(10))]
if len(gdf) == 0:
return
return get_coordinates(gdf) |
The issue seems to go away after dropping extra verts: OCSMesh/ocsmesh/cli/subset_n_combine.py Line 644 in 0563a79
OCSMesh/ocsmesh/cli/subset_n_combine.py Lines 660 to 661 in 0563a79
correction |
After the number of layers fix, if I use 8 layers, I do not get the issue with duplicate nodes, but with 9 I do!! WHY?! |
The mesh in the seam section seem to sometimes include two nodes that are almost at the same spot. See https://github.com/noaa-ocs-modeling/SurgeTeamCoordination/issues/143#issuecomment-1844362533
And example in a local test is:
File
seam_mesh.2dm
which then reappears in the final mesh as:
The text was updated successfully, but these errors were encountered: