Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: noble-assets/noble
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 391bc34a0070fb2d37e392d03d928e7ee219ea64
Choose a base ref
..
head repository: noble-assets/noble
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 287b106e117a6483d846d78219ae73a3e5d3bf10
Choose a head ref
Showing with 3 additions and 3 deletions.
  1. +3 −3 .github/workflows/module-check.yaml
6 changes: 3 additions & 3 deletions .github/workflows/module-check.yaml
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ jobs:

- name: go-mod-why
run: |
for MODULE in "${RESTRICTED_MODULES[@]}"; do
for MODULE in $RESTRICTED_MODULES; do
OUTPUT=$(go mod why -m -vendor "$MODULE")
if echo "$OUTPUT" | grep -q "main module does not need to vendor module $MODULE"; then
echo "$MODULE is not imported ✓"
@@ -35,14 +35,14 @@ jobs:
fi
done
for PACKAGE in "${RESTRICTED_PACKAGES[@]}"; do
for PACKAGE in $RESTRICTED_PACKAGES; do
OUTPUT=$(go mod why -vendor "$PACKAGE")
if echo "$OUTPUT" | grep -q "main module does not need to vendor package $PACKAGE"; then
echo "$PACKAGE is not imported ✓"
# if the shortest import path is the E2E suite, is is safe to assume the package is not used in the main module
elif echo "$OUTPUT" | grep -q "github.com/noble-assets/noble/e2e"; then
echo "$PACKAGE is not imported into main Noble module ✓"
echo "$PACKAGE is not imported into main Noble module ✓"
else
echo "$PACKAGE is currently restricted as an import in Noble ✘"
exit 1