Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show map if transform is missing #52

Closed
wants to merge 1 commit into from

Conversation

schra
Copy link
Collaborator

@schra schra commented May 3, 2019

Description

It's confusing when the map is shown but the transform is missing. This
leads to the map being on a wrong place.

Fixes #51

Test plan

Call roslaunch rviz_satellite demo.launch once with the demo.launch as is and once without the static_tf_fake.

/cc @beetleskin

It's confusing when the map is shown but the transform is missing. This
leads to the map being on a wrong place.

Fixes #51
@beetleskin
Copy link
Contributor

beetleskin commented May 5, 2019

Why not using the MessageFilterDisplay class? This should fix the issue easier, see #51 (comment).
Using this class will lead to not getting a message-callback, if the frame_id within the message is not available. Unfortunately, this does not produce an error, but the map is not rendered, as we want it to be.

@beetleskin
Copy link
Contributor

hm, actually it should produce errors if tf is not available, if I read this right: http://docs.ros.org/jade/api/rviz/html/c++/message__filter__display_8h_source.html#l00106

Copy link
Contributor

@beetleskin beetleskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs major rebase, and see conceptual comments

@schra schra added the wontfix label Dec 1, 2020
@schra schra closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show map if transform is missing
3 participants