-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<scrollArea> is broken #48
Comments
Good catch. This is a simple fix; just need time to apply it. Will involve updating the registry of components to include ... and updating the Svelte NodeGUI JSX intrinsic typings: https://github.com/nodegui/svelte-nodegui/blob/main/src/svelte-nodegui.ts Looks like the component would be an RNScrollArea under-the-hood: https://github.com/nodegui/svelte-nodegui/blob/main/src/dom/react-nodegui/src/components/ScrollArea/RNScrollArea.ts |
It might be a bit more subtle than this. I applied those changes on a fork of your code (with a few other adds to https://github.com/nodegui/svelte-nodegui/blob/main/src/index.ts and https://github.com/nodegui/svelte-nodegui/blob/main/src/dom/react-nodegui/src/index.ts) |
After a bit more testing is seems that scrollArea is kind of working but there are some strange size issues with both scrollArea and its child. See PR #53 (added scrollArea and updated demo to highlight the current problem). |
Agreed that there are size issues with both. I'm not immediately sure why. First #42 needs to be solved, to ensure that child nodes are being added correctly in the first place (which particularly impacts the |
@johanalkstal is this what you were experiencing with regular NodeGUI? Does ScrollArea not work for you? We're experiencing problems trying to get it to do anything sensible in Svelte NodeGUI and I'm wondering whether the problem stems from NodeGUI itself or not. |
The issue I have is similar to nodegui/react-nodegui#342 That is, I try to use QScrollArea with a QWidget as its child, and the QWidget contains dynamically added QLabels, but the scroll bars don't appear. |
The documentation states that any components enclosed with a
<scrollArea></scrollArea>
element should become scrollable. However when including such an element in a component, nodejs complains with aUnhandledPromiseRejectionWarning: Error: No known component for element scrollArea.
when starting the application.The text was updated successfully, but these errors were encountered: