Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linters #22

Open
joyeecheung opened this issue Dec 10, 2024 · 6 comments
Open

Add linters #22

joyeecheung opened this issue Dec 10, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@joyeecheung
Copy link
Member

I vaguely remember we published the linter rules that node.js core somewhere so that it can be reused through out the organizations. Though it's been too long since I added a new JS repo to the organization that needs it to know off the top of my head, we can probably just copy whatever https://github.com/nodejs/node-core-utils have.

@AugustinMauroy
Copy link
Member

AugustinMauroy commented Dec 14, 2024

on user-land migration and amaro we use biomejs

so we can consider biomejs

@richardlau
Copy link
Member

There's https://github.com/nodejs/eslint-plugin-nodejs-internal but I'm not sure if it's being used anywhere.

@AugustinMauroy
Copy link
Member

AugustinMauroy commented Dec 14, 2024

There's https://github.com/nodejs/eslint-plugin-nodejs-internal but I'm not sure if it's being used anywhere.

it's doesn't support eslint v9 ?
is it still maintain ?

@AugustinMauroy
Copy link
Member

Which one should we take ?

@joyeecheung
Copy link
Member Author

As long as it looks close enough to the styles used by Node.js core I think either eslint or biome works.

@joyeecheung joyeecheung added the enhancement New feature or request label Dec 21, 2024
@AugustinMauroy
Copy link
Member

+1 for biome because it's FAST, have official GA with reporter

@joyeecheung joyeecheung added the good first issue Good for newcomers label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants