Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenewOnSettle policy override is incorrect #333

Open
wingedfox opened this issue Sep 14, 2017 · 0 comments
Open

RenewOnSettle policy override is incorrect #333

wingedfox opened this issue Sep 14, 2017 · 0 comments

Comments

@wingedfox
Copy link

Hello,

I've found that RenewOnSettle override does no work because provided settings are not used by client.
https://github.com/noodlefrenzy/node-amqp10/blob/master/lib/policies/policy_utilities.js#L107
policy provides receiverLink field, but the only place it mentioned and it is not from the overrides
https://github.com/noodlefrenzy/node-amqp10/blob/master/lib/amqp_client.js#L289

Either policy or link constructor should be updated to use overrides properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wingedfox