Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit delegation for multishard wallet. Unchange voting power trigger on wallets with different lock period. #3027

Closed
stepanLav opened this issue Jan 23, 2025 · 3 comments · Fixed by #3070
Assignees
Labels
Bug Issues & PRs that addressing a bug

Comments

@stepanLav
Copy link
Member

stepanLav commented Jan 23, 2025

Description

If user has a few accounts into multishard wallet with delegations and different locked period, when he started to edit it - will be used the x1 locking period.

Test data:

spektr-database.json

Steps to Reproduce

  1. Load test data
  2. Select mister-coin wallet
  3. Go to Governance
  4. Select test network
  5. Go to delegations
  6. Try to edit delegations for all accounts

Expected Behavior

Pre-field state won't trigger, because locking period is different

Actual Behavior

Pre-filed state triggered with x1 loking period

Kapture.2025-01-23.at.11.05.30.mp4

Environment

b445163

@stepanLav stepanLav added the Bug Issues & PRs that addressing a bug label Jan 23, 2025
@Asmadek Asmadek self-assigned this Jan 23, 2025
@Asmadek Asmadek moved this from Todo to In Review in Nova Spektr development Jan 23, 2025
@Asmadek Asmadek linked a pull request Jan 23, 2025 that will close this issue
@Asmadek Asmadek moved this from In Review to Ready for Test in Nova Spektr development Jan 23, 2025
@stepanLav stepanLav moved this from Ready for Test to Testing in Nova Spektr development Jan 30, 2025
@stepanLav
Copy link
Member Author

stepanLav commented Jan 30, 2025

Status verification: ❌

What has been verified:

Unchanged voting power should trigger if locking period the same ✅

Unchanged voting power should NOT trigger if locking period is different ❌

Example:

Kapture.2025-01-30.at.13.06.09.mp4

Expected result:
When user has different locking periods unchanged check-box won't trigger
Actual result:
When user has different locking periods triggers unchanged check-box

When trigger unchanged voting power, locking period should not be available and set to actual position ❌

When Unchanged voting power is active - locking period always set to x0.1 which may mess up the user

Example:

Kapture.2025-01-30.at.13.01.56.mp4

Expected result:
Actual loking period - x1
Loking period on setup page - x1

Actual result:
Actual loking period - x1
Loking period on setup page - x0.1

@stepanLav stepanLav moved this from Testing to Todo in Nova Spektr development Jan 30, 2025
@Asmadek Asmadek removed a link to a pull request Jan 30, 2025
@Asmadek Asmadek linked a pull request Jan 30, 2025 that will close this issue
@Asmadek Asmadek moved this from Todo to In Review in Nova Spektr development Jan 30, 2025
@Asmadek Asmadek moved this from In Review to Ready for Test in Nova Spektr development Jan 30, 2025
@stepanLav stepanLav moved this from Ready for Test to Testing in Nova Spektr development Jan 31, 2025
@stepanLav
Copy link
Member Author

Status verification: ❌

What has been verified:

#3077

@stepanLav
Copy link
Member Author

Status verification: ✅

@stepanLav stepanLav moved this from Testing to Done in Nova Spektr development Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues & PRs that addressing a bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants