Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure proxy. Multisig operation. Crash on Operations page #3081

Closed
stepanLav opened this issue Jan 31, 2025 · 2 comments · Fixed by #3083
Closed

Pure proxy. Multisig operation. Crash on Operations page #3081

stepanLav opened this issue Jan 31, 2025 · 2 comments · Fixed by #3083
Assignees
Labels
Bug Issues & PRs that addressing a bug

Comments

@stepanLav
Copy link
Member

Description

When user creates vote operation from pure proxy it crash the app on Operations list

Test data

spektr-database.json

Steps to Reproduce

  1. Add setup Multisig + Pure proxy
  2. Creates multisig vote operation via pure proxy
  3. Go to Multisig wallet
  4. Go to Operations page
  5. Try to open created operation

Expected Behavior

Successfully opened

Actual Behavior

Crash on Operations list

Kapture.2025-01-31.at.10.56.51.mp4

Environment

19bf20d

@stepanLav
Copy link
Member Author

The reason is that in getVotes put amount with wrong format:

const getVotes = (vote: TransactionVote): BN => {

SplitAbstain: {abstain: "1,000,000,000,000”, aye: “0”, nay: “0”}

vs

SplitAbstain: {abstain: "1000000000000”, aye: “0”, nay: “0”,type: "SplitAbstain”}

@sokolova-an sokolova-an self-assigned this Jan 31, 2025
@sokolova-an sokolova-an moved this from Todo to Development in Nova Spektr development Jan 31, 2025
@sokolova-an sokolova-an moved this from Development to Ready for Test in Nova Spektr development Jan 31, 2025
@stepanLav stepanLav moved this from Ready for Test to Testing in Nova Spektr development Jan 31, 2025
@stepanLav
Copy link
Member Author

Status verification: ✅

@stepanLav stepanLav moved this from Testing to Done in Nova Spektr development Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues & PRs that addressing a bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants