Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer confirm. Sign button is not available if validation fall with error. #3095

Closed
stepanLav opened this issue Feb 3, 2025 · 1 comment · Fixed by #3096
Closed

Transfer confirm. Sign button is not available if validation fall with error. #3095

stepanLav opened this issue Feb 3, 2025 · 1 comment · Fixed by #3096
Assignees
@tuul-wq
Labels
Bug Issues & PRs that addressing a bug

Comments

@stepanLav
Copy link
Member

Description

Silent validation error on confirm:

https://github.com/novasamatech/nova-spektr/blob/v1.14.1/src/renderer/features/operations/OperationsConfirm/Transfer/model/confirm-model.ts#L69

Expected Behavior

Error is shown

Actual Behavior

Sign button is not available

Environment

718ca6b
@stepanLav stepanLav added the Bug Issues & PRs that addressing a bug label Feb 3, 2025
@stepanLav stepanLav assigned tuul-wq and unassigned pgolovkin Feb 3, 2025
@tuul-wq tuul-wq moved this from Todo to Development in Nova Spektr development Feb 3, 2025
@tuul-wq tuul-wq mentioned this issue Feb 3, 2025
Merged
@tuul-wq tuul-wq moved this from Development to In Review in Nova Spektr development Feb 3, 2025
@tuul-wq tuul-wq moved this from In Review to Ready for Test in Nova Spektr development Feb 3, 2025
@stepanLav stepanLav moved this from Ready for Test to Testing in Nova Spektr development Feb 4, 2025
@stepanLav
Copy link
Member Author

Status verification: ✅

What has been verified:

  • Multisig wallet has no balance in multisig.as_multi(proxy.proxy(transfer)) from pure proxy
  • Multisig wallet has no balance in proxy.proxy(multisig.as_multi(transfer)) from regular proxy

@stepanLav stepanLav moved this from Testing to Done in Nova Spektr development Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tuul-wq tuul-wq

Labels
Bug Issues & PRs that addressing a bug
Projects
Nova Spektr development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Missing validation novasamatech/nova-spektr
3 participants
@pgolovkin @tuul-wq @stepanLav