Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for NpgsqlDataSource #2400

Closed
roji opened this issue Jun 7, 2022 · 0 comments · Fixed by #2429
Closed

Basic support for NpgsqlDataSource #2400

roji opened this issue Jun 7, 2022 · 0 comments · Fixed by #2429
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@roji
Copy link
Member

roji commented Jun 7, 2022

With NpgsqlDataSource getting implemented at the ADO.NET layer (npgsql/npgsql#4495), we'll need to react in the EF provider.

As a first basic step, accept an NpgsqlDataSource in UseNpgsql rather than a connection string.

We could also obsolete providing the SSL/TLS callbacks directly on the EF options builder. However, we had a similar ADO discussion about whether to obsolete the SSL/TLS callbacks on NpgsqlConnection, and decided against it for now; we should do the same in EF (i.e. obsolete the EF options builder hooks when we obsolete the NpgsqlConnections ones).

We can also think about improving type mapping customization support (plugins and enums), but that's complex; tracked by #2518 for the future.

@roji roji added the enhancement New feature or request label Jun 7, 2022
@roji roji added this to the 7.0.0 milestone Jun 7, 2022
@roji roji self-assigned this Jun 7, 2022
roji added a commit to roji/efcore.pg that referenced this issue Jul 13, 2022
roji added a commit to roji/efcore.pg that referenced this issue Sep 17, 2022
roji added a commit to roji/efcore.pg that referenced this issue Oct 6, 2022
roji added a commit to roji/efcore.pg that referenced this issue Oct 7, 2022
roji added a commit that referenced this issue Oct 7, 2022
@roji roji changed the title Support NpgsqlDataSource Basic support for NpgsqlDataSource Oct 7, 2022
@roji roji linked a pull request Oct 7, 2022 that will close this issue
@roji roji closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant