Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert_Rosetta_chainbreaks has an incorrect method signature #76

Open
jonlevi opened this issue Apr 2, 2024 · 0 comments
Open

insert_Rosetta_chainbreaks has an incorrect method signature #76

jonlevi opened this issue Apr 2, 2024 · 0 comments

Comments

@jonlevi
Copy link

jonlevi commented Apr 2, 2024

https://github.com/nrbennet/dl_binder_design/blame/cafa3853ac94dceb1b908c8d9e6954d71749871a/af2_initial_guess/af2_util.py#L251

According to the in-line documentation, this method (insert_Rosetta_chainbreaks in af2_util.py) can take a list of list of indices to insert chainbreaks after. However in reality the method can only take a single index at a time, and thus the arg binderlen is actually of type int and not of type list[int]. It would actually be pretty helpful if the code could be modified to generalize to more than one index at a time, but at the very least maybe just update the documentation to reflect that you can only pass one index at a time for chainbreaks.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant