Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small open_virtual_dataset bugs #923

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ayushnag
Copy link
Collaborator

@ayushnag ayushnag commented Jan 8, 2025


📚 Documentation preview 📚: https://earthaccess--923.org.readthedocs.build/en/923/

Copy link

github-actions bot commented Jan 8, 2025

Binder 👈 Launch a binder notebook on this branch for commit 8f9d27e

I will automatically update this comment whenever this PR is modified

@ayushnag ayushnag changed the title Minor open_virtual_dataset results bugs Fix small open_virtual_dataset results bugs Jan 8, 2025
@ayushnag ayushnag changed the title Fix small open_virtual_dataset results bugs Fix small open_virtual_dataset bugs Jan 8, 2025
@ayushnag
Copy link
Collaborator Author

ayushnag commented Jan 8, 2025

Note that this PR changes the dmrpp tests to no longer verify the result of open_virtual_dataset since that is checked in virtualizarr. The tests here now check that the expected dmrpp files are found, parsed, and can be loaded.

@ayushnag ayushnag requested a review from betolink January 8, 2025 19:16
@Mizokuiam
Copy link

Thank you for raising this issue! I'll look into it and try to help if I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] incorrect typing on get_s3_filesystem has led open_virtual_mfdataset astray
2 participants