Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt: Migrate from deprecated method #115

Closed
eigenbeam opened this issue Dec 11, 2024 · 4 comments
Closed

Tech Debt: Migrate from deprecated method #115

eigenbeam opened this issue Dec 11, 2024 · 4 comments
Assignees

Comments

@eigenbeam
Copy link
Contributor

In

From Julia:
one more bit of food for thought when you have a chance: The test output indicates open_text is deprecated (https://github.com/nsidc/granule-metgen/pull/101/checks) I believe you switched to using open_text -- is there a reason to use it?

From Kevin:
Yeah, the change was so that we could load the json from an installed Python package. So we don’t rely directly on the filesystem path where they reside. I had to look up how to do this, and I found, apparently, an older reference that used the now-deprecated API. It should be straightforward to update it.

@eigenbeam
Copy link
Contributor Author

#120

@juliacollins
Copy link
Contributor

PR approved!

@eigenbeam
Copy link
Contributor Author

eigenbeam commented Jan 21, 2025

@lisakaser @afitzgerrell This is an internal code change that isn't really testable. If you are okay with Julia and I saying "it's good" then I think we can mark this one done.

@lisakaser
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants