add flatten_chains and the relevant tests #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcerkoney
reviewed
Oct 25, 2023
dcerkoney
approved these changes
Oct 25, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## computgraph #150 +/- ##
===============================================
- Coverage 64.41% 64.35% -0.07%
===============================================
Files 62 62
Lines 4353 4303 -50
===============================================
- Hits 2804 2769 -35
+ Misses 1549 1534 -15
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function merge_all_chains() has a bug, as shown in the test/computation_graph.jl/line 302-308.
The added function flatten_all_chains() should fix this bug and be used in optimize!() to replace merge_all_chains().