Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatten_sum and refactor all new transform functions #171

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Conversation

fsxbhyy
Copy link
Collaborator

@fsxbhyy fsxbhyy commented Dec 24, 2023

  1. Add flatten_sum
  2. Add a map to keep track of visited nodes for all transforms
  3. Add documentations

@fsxbhyy fsxbhyy added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 24, 2023
@fsxbhyy fsxbhyy self-assigned this Dec 24, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (2a4419a) 61.54% compared to head (f94f13c) 61.01%.
Report is 1 commits behind head on computgraph.

Files Patch % Lines
src/computational_graph/transform.jl 0.00% 60 Missing ⚠️
src/computational_graph/eval.jl 88.88% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           computgraph     #171      +/-   ##
===============================================
- Coverage        61.54%   61.01%   -0.54%     
===============================================
  Files               66       66              
  Lines             5061     5112      +51     
===============================================
+ Hits              3115     3119       +4     
- Misses            1946     1993      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsxbhyy fsxbhyy merged commit ba405b3 into computgraph Dec 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants