Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the BareInteractionId comparison #174

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Conversation

kunyuan
Copy link
Member

@kunyuan kunyuan commented Jan 12, 2024

improve BareInteractionId comparison

@kunyuan kunyuan added the enhancement New feature or request label Jan 12, 2024
@kunyuan kunyuan requested a review from houpc January 12, 2024 17:32
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e21e062) 56.17% compared to head (4f59de6) 56.05%.

Files Patch % Lines
src/frontend/diagram_id.jl 95.23% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           computgraph     #174      +/-   ##
===============================================
- Coverage        56.17%   56.05%   -0.13%     
===============================================
  Files               51       51              
  Lines             4539     4526      -13     
===============================================
- Hits              2550     2537      -13     
  Misses            1989     1989              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kunyuan kunyuan merged commit d9d591d into computgraph Jan 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants