Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FrontEnds and update vertex4 #177

Merged
merged 17 commits into from
Feb 8, 2024
Merged

Refactor FrontEnds and update vertex4 #177

merged 17 commits into from
Feb 8, 2024

Conversation

houpc
Copy link
Member

@houpc houpc commented Jan 16, 2024

No description provided.

@houpc houpc added the enhancement New feature or request label Jan 16, 2024
@houpc houpc self-assigned this Jan 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (d9d591d) 56.05% compared to head (c9c441c) 54.75%.

Files Patch % Lines
src/frontend/GV.jl 37.50% 30 Missing ⚠️
src/computational_graph/tree_properties.jl 38.09% 13 Missing ⚠️
src/computational_graph/optimize.jl 55.55% 4 Missing ⚠️
src/computational_graph/graph.jl 72.72% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           computgraph     #177      +/-   ##
===============================================
- Coverage        56.05%   54.75%   -1.30%     
===============================================
  Files               51       52       +1     
  Lines             4526     5037     +511     
===============================================
+ Hits              2537     2758     +221     
- Misses            1989     2279     +290     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houpc houpc requested review from dcerkoney and fsxbhyy January 16, 2024 11:37
@houpc houpc changed the title Update vertex4 in GV Refactor FrontEnds and update vertex4 Jan 24, 2024
Copy link
Collaborator

@dcerkoney dcerkoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I think we need to add some tests before merging.

src/computational_graph/abstractgraph.jl Show resolved Hide resolved
src/computational_graph/optimize.jl Show resolved Hide resolved
src/computational_graph/tree_properties.jl Outdated Show resolved Hide resolved
src/computational_graph/tree_properties.jl Outdated Show resolved Hide resolved
src/frontend/parquet/parquet.jl Show resolved Hide resolved
Copy link
Collaborator

@dcerkoney dcerkoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me modulo a few docstring typos

src/computational_graph/optimize.jl Show resolved Hide resolved
src/computational_graph/optimize.jl Show resolved Hide resolved
src/frontend/parquet/operation.jl Outdated Show resolved Hide resolved
src/frontend/parquet/operation.jl Outdated Show resolved Hide resolved
src/frontend/parquet/operation.jl Outdated Show resolved Hide resolved
@houpc houpc merged commit 4811703 into computgraph Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants